Thread: reverse string

Code:

#include<stdio.h>
main()
{
      char buffer[50];
      char *reversed;
      gets(buffer);
      reversed=malloc(strlen(buffer)+1);
      int g,f;
      reversed[strlen(buffer)+1]='\0';
      for(g=strlen(buffer)-1,f=0;g>=0;g--,f++)
      {
          reversed[f]=buffer[g];
          }
          printf("%s",reversed);
}

&&&&&&&&&&

Code:

#include<stdio.h>
main()
{
      char buffer[50];
      char *reversed;
      gets(buffer);
      reversed=malloc(strlen(buffer)+1);
      int g,f;
      reversed[strlen(buffer)+1]='\0';
      for(g=strlen(buffer),f=0;g>=0;g--,f++)
      {
          reversed[f]=buffer[g];
          }
          printf("%s",reversed);
}

sorry for using gets and intendations and all this but i have no time really
any way the first one works because i add -1 but the second one doesn't ???
why is that ?
thanks in advance

for your informations i am using notpad and if you think my indentation sucks you see this machine :@
"What is really so pressing in your life that you can't take the time to indent code properly as you write it?"
believe me allot of crap
any way you mean when i use the strlen as index it contains the index of '\0' also
so by this i copied it to the word[] when i didn't subtracted 1
thanks any way and sorry for bothering you with my indentation

Originally Posted by maven

in the statement
for(g=strlen(buffer),f=0;g>=0;g--,f++)

problem is at "g>=0".
If string length is of 6 then it will try to traverese the string 7 times. At seventh place it will find nothing and may result ambiguos.

Simply understand
for(i=0; i<6; i++) will loop only 6 times while
for(i=0; i<=6; i++) will loop 7 times.

I think now u hav got what u r doing wrong.

no but thanks
if i did this

Code:

for(g=strlen(buffer),f=0;g>0;g--,f++)

its not gonna copy the first letter

right but look at this

Code:

]for(x=5;x>0;x++)
{
printf("%d",x);
}
=[5,4,3,2,1]

it's not gonna print 0
but

Code:

for(x=0;x>=0;x++)
{
printf("%d",x);
}
=[5,4,3,2,1,0]

You should only need one number for a for loop and the string length here.

count to the length of the string. The backwards versions position will be the length of the string minus the position in the loop -1.

thanks all for your advices
sorry for my bad indentation

Code:

   for(int i =0;i>strlen(string);i++)