What am I doing worng? Segmentation fault, core dump

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <math.h>

int main( )
{
int x;
int y;
int choice;

printf ( "Hello! This is the second version of my calculator\n" );
printf ( "Select addition or subtraction\n" );
printf ( "1.Addition\n2.Subtraction\n");
scanf ("%d", choice);

if ( choice = 1 )
    {
    printf ( "You chose addition\n" );
    printf ( "Input first integer\n" );
    scanf ("%d", x);
    printf ( "Input the second one\n" );
    scanf ("%d", y);
    printf ("%d", x + y );
    }


}

---

I do not have a code for choice 2, but why doesn't choice 1 work?
What am I doing wrong????
It just gives me a core dump, segmentation faul error after I choose 1

> scanf ("%d", x);
You forgot the &
as in
scanf ("%d", &x);

Code:

---

$ gcc -W -Wall -ansi -pedantic -O2 foo.c
foo.c: In function `main':
foo.c:14: warning: format argument is not a pointer (arg 2)
foo.c:16: warning: suggest parentheses around assignment used as truth value
foo.c:20: warning: format argument is not a pointer (arg 2)
foo.c:22: warning: format argument is not a pointer (arg 2)
foo.c:27: warning: control reaches end of non-void function
foo.c:7: warning: 'x' might be used uninitialized in this function
foo.c:8: warning: 'y' might be used uninitialized in this function
foo.c:9: warning: 'choice' might be used uninitialized in this function

---

If your compiler is gcc based, then consider increasing the warning level to spot all those scanf issues.

After you fix the error Salem noted:

Code:

---

if ( choice = 1 )

---

You want two equal signs: choice == 1. == tests for equality, = assigns a value. Your if() statement stores 1 to choice, and then boils down to if(1), something that will always prove true. Again, turning up gcc's warnings (if you're using gcc) will probably catch something like this.

> Again, turning up gcc's warnings (if you're using gcc) will probably catch something like this.
You mean the
foo.c:16: warning: suggest parentheses around assignment used as truth value

I get it now! Without that & operator, u do not tell the program to look for it!



Thanks a lot!
:)