Fill square

[ch4]

Ηelp... I have to make a program that fills a board perfect with numbers.
The first cell should always starts with number 1.
Each number should be placed only: vertically (three cells) or levelly (three cells) or across(two cells) of the previous number.

E.X.
if the given number is 5 then the result:

  
1    19    16    4     20
14    24    8    11     23
17    5    21    18      6
2    10    15     3      9
13    25     7    12     22

Here is my attempt but i can see the mistake.

#include<stdio.h>
#include<math.h>


int table (int x,int y,int s,int n);
int a[5][5];
int main (void){
    int i,j,m;
    
    /*fill the table with zero*/
    for(i=0;i<5;i++){
                     for(j=0;j<5;j++){
                                      a[i][j]=0;
                                      }
                     }
    /*get number*/
    scanf("&#37;d",&m);
    m=m*m;
    
    /*function call*/
    table(0,0,1,m);
    
    /*print the board*/
    for(i=0;i<sqrt(m);i++){
                    for(j=0;j<sqrt(m);j++){
                                   printf("%d    ",a[i][j]);
                                   }
                    putchar('\n');putchar('\n');putchar('\n');
                    }
    
    getchar();getchar();
    return 0;
    }
/*function that fills the board*/
int table (int x,int y,int s,int n){
    
        /*check conditions*/
    if((s<=n)&&(x<sqrt(n))&&(x>=0)&&(y<sqrt(n))&&(y>=0)&&(a[x][y]==0)){
                                                                     a[x][y]=s;
                                                                     
                                                                     
                                                                if(table(x,y+3,s+1,n)==1){                         /*check the next number three cells horizontally*/
                                                                                                  return 1;                    /*return 1 if every condition is correct*/
                                                                                          }
                                                                else if (table(x+2,y+2,s+1,n)==1){
                                                                                                  return 1;
                                                                                                  }
                                                                else if (table(x+3,y,s+1,n)==1){
                                                                                                  return 1;
                                                                                                }
                                                                else if (table(x+2,y-2,s+1,n)==1){
                                                                                                  return 1;
                                                                                                  }
                                                                else if (table(x-3,y,s+1,n)==1){
                                                                                                  return 1;
                                                                                                }
                                                                else if (table(x-2,y-2,s+1,n)==1){
                                                                                                  return 1;
                                                                                                  }
                                                                else if (table(x,y-3,s+1,n)==1){
                                                                                                  return 1;
                                                                                                }
                                                                else if (table(x-2,y+2,s+1,n)==1){
                                                                                                  return 1;
                                                                                                  }
                                                                else{                                     /*if no condition is correct then delete the number and return 0*/
                                                                     a[x][y]=0;                         /*in order to check somewhere else*/
                                                                     return 0; }
                                                                     
                                                                     }
     
                   
     if(s<n)
              return 2;
               
     return 1;   
        }

[MacGyver]

I'm totally lost at what you're trying to do. Either I need to get some rest, or this makes little to no sense.

I understand you want to build a table of some sort, but I don't know what the relationship of the numbers is, if any at all. Your table() function has some ugly calculations and recursion, and in its current form, is not easy to read.

[robatino]

Numbers are successively entered into the table, with each number located either 3 vertically, 3 horizontally, or 2 diagonally from the previous number. But it doesn't look easy to carry out.

[MacGyver]

Aha, I finally understand it! I think I might celebrate.

IMO, the first problem is that the table() function is way too complicated. If the algorithm could be simplified, it would probably help.

[Adak]

I was wondering what the heck "levelly" meant!

Instead of one GIGANTIC if statement, and the World's LONGEST tab settings, why don't you bring this back down to earth with much simpler logic statements AND a tab setting of from 2 to 5 spaces.

A few comments to describe just what you're doing/trying to do with your logic, in the table() function, would be very good to have, as well.

I'm confused why 's' is always just 1, in the call to table() ?

[ch4]

Hi
levelly it means horizontally.

Check my example:
ALWAYS in the first cell should be placed number 1
2 is situated three cells donw vertically from 1
3 is situated three cells left horizontaly from 2
4 is situated three cells up vertically from 3
5 is situated two cells across from 4 etc...

The board should be filled perfect acording the rules without blanck cells.
if you check my program for 5 you will see what i mean.

It works flashbacking:
it checks for each number the conditions for it's next.

[zacs7]

And if your scanf() fails?

You just continue on... So add some error checking!

[ch4]

i do not mind if scanf() fails i will fix the detail at the end

[zacs7]

scanf("%d", &m);
m = m*m;

/me thinks

char buf[16];
fgets(buf, sizeof(buf); stdin);
if(sscanf(buf, "%d", &m) != 1)
{
    perror("m, not an int");
    return 1;
}
m *= m;

I also wouldn't hardcode the bounds of your 2D array...

[ch4]

Thanks Everyone.

I made it. I built the program i was talking to.
So grab the code and check it to see what i mean.

#include<stdio.h>
#include<math.h>


int table (int x,int y,int s,int n);
int ** a;
int main (void){
    int i,j,m;
    
     
    printf("\t\t\t*<-- SQUARES -->*\n\n");
    printf("Give the number , whom the square you want to be filled : ");
   
     
    scanf("&#37;d",&m);
    
     
    a=malloc (m * sizeof (int *));
    for(i=0;i<m;i++)
                    a[i]=malloc (m * sizeof (int));
                    
    putchar('\n');                
                    
     
     for(i=0;i<m;i++){
                     for(j=0;j<m;j++){
                                      a[i][j]=0;
                                      }
                     }
     
    m=m*m;
    
     
    table(0,0,1,m);
    
    
     
    for(i=0;i<sqrt(m);i++){
                    for(j=0;j<sqrt(m);j++){
                                           if(a[i][j]<10)
                                                        printf(" %d    ",a[i][j]);
                                           else
                                                        printf("%d    ",a[i][j]);
                                   }
                    putchar('\n');putchar('\n');putchar('\n');
                    }
    
    getchar();getchar();
    return 0;
    }

int table (int x,int y,int s,int n){
    
     
    if((s<=n)&&(x<sqrt(n))&&(x>=0)&&(y<sqrt(n))&&(y>=0)&&(a[x][y]==0))
          {                                                           
           a[x][y]=s;                                                          
                                                                     
           if(table(x,y+3,s+1,n)==1){
                                            return 1;
                                    }
           else if (table(x+2,y+2,s+1,n)==1){
                                            return 1;
                                             }
           else if (table(x+3,y,s+1,n)==1){
                                            return 1;
                                           }
           else if (table(x+2,y-2,s+1,n)==1){
                                            return 1;
                                             }
           else if (table(x-3,y,s+1,n)==1){
                                            return 1;
                                           }
           else if (table(x-2,y-2,s+1,n)==1){
                                            return 1;
                                             }
           else if (table(x,y-3,s+1,n)==1){
                                            return 1;
                                           }
           else if (table(x-2,y+2,s+1,n)==1){
                                            return 1;
                                             }
           else{
                a[x][y]=0;
                return 0; 
                }
                                                                     
          }                  
     else if(s<=n)            
              return 0;
     else if(s==n+1)          
         return 1;            

        }

Just try it for numbers >5
Now my problem is to make it faster.

[vart]

I don't understand why do you firstly make m = m*m
and then here and there use sqrt(m)

Use the original value, discard all uses of sqrt and calculate m*m anly where needed... (And I haven't read your algorithm...)

[ch4]

I calculate m=m*m because i want to fill the table with all numbers from 1 to square of the given number.
I use sqrt(n) in order to be sure that the program will not "look" out of my table.
Take a look of my examples.

[dwks]

What vart means is this. Why not replace this

    m=m*m;
    
     
    table(0,0,1,m);
    
    
     
    for(i=0;i<sqrt(m);i++){
                    for(j=0;j<sqrt(m);j++){
                                           if(a[i][j]<10)
                                                        printf(" &#37;d    ",a[i][j]);
                                           else
                                                        printf("%d    ",a[i][j]);
                                   }
                    putchar('\n');putchar('\n');putchar('\n');
                    }
    
    getchar();getchar();
    return 0;
    }

with this?

    /* m=m*m; */
    
     
    table(0,0,1,m*m);
    
    
     
    for(i=0;i<m;i++){
                    for(j=0;j<m;j++){
                                           if(a[i][j]<10)
                                                        printf(" %d    ",a[i][j]);
                                           else
                                                        printf("%d    ",a[i][j]);
                                   }
                    putchar('\n');putchar('\n');putchar('\n');
                    }
    
    getchar();getchar();
    return 0;
    }

sqrt() is rather expensive to calculate, so it is best if you can avoid doing so, especially in a loop as you have it.

Note that I didn't look too closely at your code, I just echoed what vart said.