Problem with using a union into a struct :)

Hi to all!

I'm trying to use a union into a struct.

I do:

Code:

#include <stdio.h>

typedef struct hello{
int x;
}hello;


typedef struct hey {

union p{

int l = 8;
hello *ptr;

}types;

int l;

}hey;

int main() {


}

and i get those warning and errors!

union.c:12: warning: no semicolon at end of struct or union
union.c:12: error: parse error before '=' token
union.c:12: warning: no semicolon at end of struct or union
union.c:15: error: parse error before '}' token
union.c:15: warning: data definition has no type or storage class
union.c:19: error: parse error before '}' token
union.c:19: warning: data definition has no type or storage class


What do i do wrong?

Thanks in advance!

You can't assign a value to a union member inside of the union definition.

Yes you are right! Thanks!
Also, i have to add sthg else in order for the program to be compiled properly
I shall add :

Code:

#include <stdio.h>

typedef struct hello{
int x;
}hello;

typedef struct hey {

union p{

int l = 8;
struct hello *ptr;

}types;

int l;

}hey;

int main() {

}

Also if i do:

struct hello{

boolean x;

};

I get the error : error: parse error before "boolean"

So that means that i can't define a boolean variable in a struct. Am i right or not?

Thanks in advance

Is it so hard to use indentation?

Well right now the program is small so indentation comes afterwards the program compiles (according to me of course )
If it was very long I would use indentation

So, can we define a boolean into a struct???

Thanks, in advance

No, indentation should come first as you write. It's meant to make the code easier to read, and hence easier to debug, maintain, etc.

boolean isn't a datatype in C, so unless you define it yourself, or it's defined in some library, you can't use it.

Here's an indented -- and slightly altered -- version of your program:

Code:

#include <stdio.h>

typedef struct hello
{
	int x;
}hello;

typedef struct hey
{
	union p
	{
		int l;
		struct hello *ptr;
	}types;
	int l;
}hey;

int main(void)
{
	return 0;
}

Much easier to read, isn't it?

Modified again:

Code:

#include <stdio.h>

typedef struct
{
	int x;
}hello;

typedef struct
{
	union
	{
		int l;
		hello *ptr;
	} types;
	int l;
}hey;

int main(void)
{
	return 0;
}

Originally Posted by g_p

Well right now the program is small so indentation comes afterwards the program compiles (according to me of course )
If it was very long I would use indentation

.thgir ot tfel morf srettel eht tup d'I ,egassem gnol a saw siht fI.

Thank you guys!

Yeah sure, the program is more easy for reading

Thanks!

Maybe you never thought about it but indentation should be done WHILE you're coding to make it easier for you to spot mistakes. Things like missing closing braces or wrongly put semicolons are easier to spot if you indent asap.

You could also use an editor like eclipse with auto-code formatting and use that every now and then.

Originally Posted by KONI

Maybe you never thought about it but indentation should be done WHILE you're coding to make it easier for you to spot mistakes. Things like missing closing braces or wrongly put semicolons are easier to spot if you indent asap.

Not only that, but it's much easier to do WHILE writing the code, since if one mechanically types each closing brace immediately after the corresponding open brace, one doesn't have to hunt down later which brace matches which.