File Handling

While reading strings from a file, I'm having a lil problem, what's wrong here it doesnt give any error or warning but while running it gets crashed.

Code:

int main(){
    FILE* r;
    int i=0; int k=0;
    int number[SIZE];
    int number2[SIZE];
    char *name[SIZE];
    char *name2[SIZE];
    
    r=fopen("xxx.dat","r");
    for ( i=0;i<SIZE;i++){
        name[i]=(char*)malloc(15*sizeof(char));
        name2[i]=(char*)malloc(15*sizeof(char ));
        }
i=0;

    do{
          fscanf( r,"%d %s %s %d",&number[i],&name[i],&name2[i],&number2[i]);
          i++;}while(i!=SIZE); //I put the string's anpersants away but still gets crashed.

Originally Posted by m0ntana

While reading strings from a file, I'm having a lil problem, what's wrong here it doesnt give any error or warning but while running it gets crashed.

Code:

int main(){
    FILE* r;
    int i=0; int k=0;
    int number[SIZE];
    int number2[SIZE];
    char *name[SIZE];
    char *name2[SIZE];
    
    r=fopen("xxx.dat","r");
    for ( i=0;i<SIZE;i++){
        name[i]=(char*)malloc(15*sizeof(char));
        name2[i]=(char*)malloc(15*sizeof(char ));
        }
i=0;

    do{
          fscanf( r,"&#37;d %s %s %d",&number[i],&name[i],&name2[i],&number2[i]);
          i++;}while(i!=SIZE); //I put the string's anpersants away but still gets crashed.

Anyway I've solved the problem by doing this

Code:

do{
          fscanf( r,"%d %s %s %d",&number[i],&temp,&temp2,&number2[i]);
          strcpy(name[i],temp);
          strcpy(name2[i],temp2);
          i++;}while(i!=SIZE);

Stop using & where you don't need them.
Whilst they're harmless if you have an array, when you have a pointer, it's a disaster.

Assuming you're not overflowing the strings, then this should work.
fscanf( r,"%d %s %s %d",&number[i],name[i],name2[i],&number2[i]);

Originally Posted by Salem

Stop using & where you don't need them.
Whilst they're harmless if you have an array, when you have a pointer, it's a disaster.

Assuming you're not overflowing the strings, then this should work.
fscanf( r,"%d %s %s %d",&number[i],name[i],name2[i],&number2[i]);

Hi Salem,

Usually I dont use & while reading strings but when it doesn't work and get crashed, I tried to do by using it..anyway Even if I'm not overflowing the strings (maybe less not over) , it still blows off... That's why I used a temp string, and solved my problem by reading into temp and copying them into actual strings that I wanted to use...