Filling an array

Hi I am trying to fill this array with 7 values that correspond to a certain id number. This is what I come up with so far, but it appears to be crashing the program. Not sure what I'm doing wrong. I want the array to hold the pay rates and then print them out.

Code:

---

//Doug Miller


#include <stdio.h>

#include <conio.h>

#include "util.h"

#define MAX_ARRAY 7

int id[MAX_ARRAY] =
{1111, 2222, 3333, 4444, 5555, 6666, 7777};

float pay_Rate[MAX_ARRAY] = {0.0};

int hour[MAX_ARRAY] = {0};

float salary[MAX_ARRAY] = {0.0};
 
void get_Pay_Rate (int id[], float pay_Rate[]);

int main()

{

int i = 0;

get_Pay_Rate(id, pay_Rate);

for (i = 0; i < MAX_ARRAY; i++)
{
printf("%.2f", pay_Rate[i]);
}

}//END OF MAIN


void get_Pay_Rate (int id[], float pay_Rate[])
{
       

        int i = 0;
        int emp_Count = 0;
        float pay_Rates = 0.0;
       
        printf("Please enter pay rates that match the following Id's! \n\n");
        for (i = 0; i < MAX_ARRAY; i++)
        {
                        for (i = 0; i < MAX_ARRAY; i++)
                        {
                        printf("\n\nPlease enter the pay rate that matches this Id, %d\n\n", id[i]);
                        scanf_s("%f", &pay_Rates);
                                if (pay_Rates < 6.0)
                                {
                                        printf("You have entered an invalid payrate; please try again!\n\n");
                                        break;
                                }
                                else
                                {
                                pay_Rate[i] = pay_Rates;
                                }
                }
        }

}  // End of get_payRate

---

Code:

---

        for (i = 0; i < MAX_ARRAY; i++)
        {
                        for (i = 0; i < MAX_ARRAY; i++)

---

Don't reuse loop variables in nested loops, or you'll regret it. :)

What is scanf_s()? How does it differ from regular old scanf()?

BTW, I think perhaps that there is something wrong with your logic here:

Code:

---

                        for (i = 0; i < MAX_ARRAY; i++)
                        {
                        printf("\n\nPlease enter the pay rate that matches this Id, &#37;d\n\n", id[i]);
                        scanf_s("%f", &pay_Rates);
                                if (pay_Rates < 6.0)
                                {
                                        printf("You have entered an invalid payrate; please try again!\n\n");
                                        break;
                                }
                                else
                                {
                                pay_Rate[i] = pay_Rates;
                                }
                }

---

Maybe, instead of the for loop, you want something like

Code:

---

do {
    /* ... */
} while(pay_Rates < 6.0);

---

[edit] You don't use conio.h, so you don't have to include it. If util.h needs conio.h then it should include it itself. [/edit]

hmm I'm not sure if you understand what I'm trying to do. Before I enter a pay rate I need it to correspond to the id number before hand. This means I need to have the print line include the right id each time. My program works with entering the data. It's displaying the id's and then asking for the rate. However I'm not sure why it's not saying the array and then printing it.

When I modified the code to this

I get an endless loop...

and visual studio says that scanf_s is just a safer function than scanf says I should use it... lol dunno

Code:

---

//Doug Miller

#include <stdio.h>

#include <conio.h>

#define MAX_ARRAY 7

int id[MAX_ARRAY] =
{1111, 2222, 3333, 4444, 5555, 6666, 7777};

float pay_Rate[MAX_ARRAY] = {0.0};

int hour[MAX_ARRAY] = {0};

float salary[MAX_ARRAY] = {0.0};
 
void get_Pay_Rate (int id[], float pay_Rate[]);

int main()

{

int i = 0;

get_Pay_Rate(id, pay_Rate);

for (i = 0; i < MAX_ARRAY; i++)
{
printf("%.2f", pay_Rate[i]);
}

_getch;

return 0;

}//END OF MAIN


void get_Pay_Rate (int id[], float pay_Rate[])
{
       

        int i = 0;
        int emp_Count = 0;
        float pay_Rates = 0.0;
       
        printf("Please enter pay rates that match the following Id's! \n\n");
        for (i = 0; i < MAX_ARRAY; i++)
        {
                        for (emp_Count = 0; emp_Count < MAX_ARRAY; emp_Count++)
                        {
                        printf("\n\nPlease enter the pay rate that matches this Id, %d\n\n", id[emp_Count]);
                        scanf("%f", &pay_Rates);
                                if (pay_Rates < 6.0)
                                {
                                        printf("You have entered an invalid payrate; please try again!\n\n");
                                        break;
                                }
                                else
                                {
                                pay_Rate[i] = pay_Rates;
                                }
                }
        }

}  // End of get_payRate

---

I think I understand what you're trying to do, though I'm not certain. Is this what you want?

Code:

---

void get_Pay_Rate (int id[], float pay_Rate[])
{
       

        int i = 0;
        int emp_Count = 0;
        float pay_Rates = 0.0;
       
        printf("Please enter pay rates that match the following Id's! \n\n");
        for (i = 0; i < MAX_ARRAY; i++)
        {
                        for(;;)
                        {
                        printf("\n\nPlease enter the pay rate that matches this Id, &#37;d\n\n", id[i]);
                        scanf_s("%f", &pay_Rates);
                                if (pay_Rates < 6.0)
                                {
                                        printf("You have entered an invalid payrate; please try again!\n\n");
                                        //break;
                                }
                                else
                                {
                                pay_Rate[i] = pay_Rates;
                                break;
                                }
                }
        }

}  // End of get_payRate

---

No that's appears to also be an endless loop and isn't incrementing the id number like mine was.

Is this what you want? It looks like you're looping way too much and reusing i when you want to continue on an error and really do nothing:

Code:

---

// D. Burke (Noir)
#include <stdio.h>


#define MAX_ARRAY 7


void get_payrate( int id[], float payrate[], int size );
void put_payrate( int id[], float payrate[], int size );


int main( void ) {
  int id[MAX_ARRAY] = {1111, 2222, 3333, 4444, 5555, 6666, 7777};
  float payrate[MAX_ARRAY] = {0};

  get_payrate( id, payrate, MAX_ARRAY );
  printf( "The IDs and Payrates are:\n" );
  put_payrate( id, payrate, MAX_ARRAY );

  return 0;
}


void get_payrate( int id[], float payrate[], int size ) {
  int i = 0;

  for ( i = 0; i < size; ) {
    printf( "ID: %d\tPayrate: ", id[i] );
    fflush( stdout );

    if ( scanf( "%f", &payrate[i] ) == 1 ) {
      if ( payrate[i] < 6.0 )  {
        printf( "invalid payrate\n" );
        continue;
      } else {
        ++i;
      }
    }
  }
}


void put_payrate( int id[], float payrate[], int size ) {
  int i;

  for ( i = 0; i < size; i++ ) {
    printf( "ID: %d\tPayrate: %.2f\n", id[i], payrate[i] );
  }
}

---

Quote:

---

Originally Posted by GCNDoug

No that's appears to also be an endless loop and isn't incrementing the id number like mine was.

---

It is incrementing i:

Code:

---

for (i = 0; i < MAX_ARRAY; i++)

---

And it isn't an endless loop:

Code:

---

break;

---

That was just one way of coding it. You could easily use do and while(x>=6.0) etc.

[edit] In short, what it does is: for each id, gets the pay_rate. Continues getting the pay_rate while it is an invalid rate. I thought that was what you wanted.

Or see Noir's code.[/edit]

Code:

---

void put_payrate( int id[], float payrate[], int size ) {
  int i;

  for ( i = 0; i < size; i++ ) {
    printf( "ID: &#37;d\tPayrate: %.2f\n", id[i], payrate[i] );
  }
}

---

Wow, that works pretty well but the print still isn't working. Also why did you use size, instead of the global for the size of the array?

I'm prob not going to able to use that code lol cause we haven't used some of that stuff in class. Does anyone see why mine was an endless loop?

Quote:

---

Wow, that works pretty well but the print still isn't working.

---

Then it doesn't work pretty well, does it? :rolleyes: How isn't it working? It takes the payrate that matches the id and prints them in pairs, just like they were entered. If that's not what you want, be really specific because I don't understand.

Quote:

---

Also why did you use size, instead of the global for the size of the array?

---

So that you're not tied to that macro all over your code if you decide to do something different. Each function should be independent of the rest of the code if possible.

After it takes all of the id's and pay rates it's not printing them at all; the command program just closes. lol

Perhaps you need to look at this? http://faq.cprogramming.com/cgi-bin/...&id=1043284385

Just add this to the end of main() and it should work:

Code:

---

while(getchar() != '\n');
getchar();

---

[edit] Noir has the same idea. :) [/edit]

That's different. The code works fine, your compiler just tricks you into thinking it doesn't by closing the window right away. Add the blue parts:

Code:

---

int main( void ) {
  int id[MAX_ARRAY] = {1111, 2222, 3333, 4444, 5555, 6666, 7777};
  float payrate[MAX_ARRAY] = {0};

  get_payrate( id, payrate, MAX_ARRAY );
  printf( "The IDs and Payrates are:\n" );
  put_payrate( id, payrate, MAX_ARRAY );

  while ( getchar() != '\n' );
  getchar();

  return 0;
}

---

Thanks a lot I figured modified your code just a little bit to change the some of the stuff we don't really use in class. All it need liked you said was the _getch(). Also is this "fflush( stdout );" just clearing the buffer?

> _getch()
getchar() is preferable if you don't mind hitting the enter key, because it is standard and _getch() is not.

Quote:

---

Also is this "fflush( stdout );" just clearing the buffer?

---

Yes. Data printed to the screen is not guaranteed to be displayed if it doesn't end with a newline (I think), so one should use fflush() in that case. Files are different.

[edit] My connection must be a fraction of a second faster than Noir's. :) [/edit]

[edit=2] Even if you were using _getch(), don't forget to add the parentheses. [/edit]

Quote:

---

All it need liked you said was the _getch().

---

_getch() isn't portable, you should be using getchar() instead. It doesn't do exactly the same thing, but it's close enough not to matter.

Quote:

---

Also is this "fflush( stdout );" just clearing the buffer?

---

It makes sure that the message is really printed before scanf() starts waiting for input. If it isn't, the user will sit around wondering what to do. :)

Quote:

---

Originally Posted by dwks

Yes. Data printed to the screen is not guaranteed to be displayed if it doesn't end with a newline (I think), so one should use fflush() in that case. Files are different.

---

Yes. By default, stdout/stdin are line buffered, unless they have been redirected to a file. (The standard actually says that it's line buffered if it is connected to an "active device", a.k.a. a terminal.) All other FILE objects are fully buffered by default. So if you are fprintf()'ing to a file, even a newline won't necessarily cause a flush.

Always flush when you print any sort of prompt. And it's usually a good idea to flush whenever you are printing debug or log messages. If your program crashes, whatever data is in the buffer won't get flushed. That data might contain critical information that could help you solve the crash, so you should ensure that it actually gets flushed.

Here is what I have no besides your size variable lol.

Code:

---

void get_Pay_Rate (int id[], float pay_Rate[], int hour[])
{
       

        int i = 0;
        int emp_Count = 0;
        float pay_Rates = 0.0;
       
        printf("Please enter pay rates that match the following Id's! \n\n");
        for (i = 0; i < MAX_ARRAY;)
        {
                        printf( "ID: %d\tPayrate: \tHours: ", id[i] );
                        fflush( stdout );
                        scanf_s("%f", &pay_Rate[i]);
                        scanf_s("%d", &hour[i]);
                                if (pay_Rate[i] < 6.0)
                                {
                                        printf("You have entered an invalid payrate; please try again!\n\n");
                                        continue;
                                }
                                else if (hour[i] < 0)
                                {
                                        printf("You have entered an invalid amount of hours; please try again!\n\n");
                                        continue;
                                }
                                else
                                {
                                i++;
                                }               
        }

}  // End of get_payRate

---

what do I need to do to make all the inputs line up nice? The hours input lines up nicely but the other doesn't.

Umm . . . print some extra spaces?

Lining things up really only works if the data isn't being entered dynamically or if you're only entering one thing at the end of the line like with the id and payrate. You have to hit enter to send input to the program, so something like this might be better:

Code:

---

printf( "\nID: %d\nPayrate: ", id[i] );
fflush( stdout );
scanf_s("%f", &pay_Rate[i]);
printf( "Hours: " );
fflush( stdout );
scanf_s("%d", &hour[i]);

---

That puts everything nicely on a single line and groups them together. It's not as concise, but it works for any number of fields.