Thread: Filling an array

Code:

	for (i = 0; i < MAX_ARRAY; i++)
	{
			for (i = 0; i < MAX_ARRAY; i++)

Don't reuse loop variables in nested loops, or you'll regret it.

What is scanf_s()? How does it differ from regular old scanf()?

BTW, I think perhaps that there is something wrong with your logic here:

Code:

			for (i = 0; i < MAX_ARRAY; i++)
			{
			printf("\n\nPlease enter the pay rate that matches this Id, &#37;d\n\n", id[i]);
			scanf_s("%f", &pay_Rates);
				if (pay_Rates < 6.0) 
				{
					printf("You have entered an invalid payrate; please try again!\n\n");
					break;
				}
				else 
				{
				pay_Rate[i] = pay_Rates;
				}
		}

Maybe, instead of the for loop, you want something like

Code:

do {
    /* ... */
} while(pay_Rates < 6.0);

[edit] You don't use conio.h, so you don't have to include it. If util.h needs conio.h then it should include it itself. [/edit]

hmm I'm not sure if you understand what I'm trying to do. Before I enter a pay rate I need it to correspond to the id number before hand. This means I need to have the print line include the right id each time. My program works with entering the data. It's displaying the id's and then asking for the rate. However I'm not sure why it's not saying the array and then printing it.

When I modified the code to this

I get an endless loop...

and visual studio says that scanf_s is just a safer function than scanf says I should use it... lol dunno

Code:

//Doug Miller

#include <stdio.h>

#include <conio.h>

#define MAX_ARRAY 7

int id[MAX_ARRAY] = 
{1111, 2222, 3333, 4444, 5555, 6666, 7777};

float pay_Rate[MAX_ARRAY] = {0.0};

int hour[MAX_ARRAY] = {0};

float salary[MAX_ARRAY] = {0.0}; 
 
void get_Pay_Rate (int id[], float pay_Rate[]);

int main()

{

int i = 0;

get_Pay_Rate(id, pay_Rate);

for (i = 0; i < MAX_ARRAY; i++)
{
printf("%.2f", pay_Rate[i]);
}

_getch;

return 0;

}//END OF MAIN


void get_Pay_Rate (int id[], float pay_Rate[])
{
	

	int i = 0;
	int emp_Count = 0;
	float pay_Rates = 0.0;
	
	printf("Please enter pay rates that match the following Id's! \n\n");
	for (i = 0; i < MAX_ARRAY; i++)
	{
			for (emp_Count = 0; emp_Count < MAX_ARRAY; emp_Count++)
			{
			printf("\n\nPlease enter the pay rate that matches this Id, %d\n\n", id[emp_Count]);
			scanf("%f", &pay_Rates);
				if (pay_Rates < 6.0) 
				{
					printf("You have entered an invalid payrate; please try again!\n\n");
					break;
				}
				else 
				{
				pay_Rate[i] = pay_Rates;
				}
		}
	}

}  // End of get_payRate

I think I understand what you're trying to do, though I'm not certain. Is this what you want?

Code:

void get_Pay_Rate (int id[], float pay_Rate[])
{
	

	int i = 0;
	int emp_Count = 0;
	float pay_Rates = 0.0;
	
	printf("Please enter pay rates that match the following Id's! \n\n");
	for (i = 0; i < MAX_ARRAY; i++)
	{
			for(;;)
			{
			printf("\n\nPlease enter the pay rate that matches this Id, &#37;d\n\n", id[i]);
			scanf_s("%f", &pay_Rates);
				if (pay_Rates < 6.0) 
				{
					printf("You have entered an invalid payrate; please try again!\n\n");
					//break;
				}
				else 
				{
				pay_Rate[i] = pay_Rates;
				break;
				}
		}
	}

}  // End of get_payRate

Originally Posted by GCNDoug

No that's appears to also be an endless loop and isn't incrementing the id number like mine was.

It is incrementing i:

Code:

for (i = 0; i < MAX_ARRAY; i++)

And it isn't an endless loop:

Code:

break;

That was just one way of coding it. You could easily use do and while(x>=6.0) etc.

[edit] In short, what it does is: for each id, gets the pay_rate. Continues getting the pay_rate while it is an invalid rate. I thought that was what you wanted.

Or see Noir's code.[/edit]

Code:

void put_payrate( int id[], float payrate[], int size ) {
  int i;

  for ( i = 0; i < size; i++ ) {
    printf( "ID: &#37;d\tPayrate: %.2f\n", id[i], payrate[i] );
  }
}

Wow, that works pretty well but the print still isn't working. Also why did you use size, instead of the global for the size of the array?

I'm prob not going to able to use that code lol cause we haven't used some of that stuff in class. Does anyone see why mine was an endless loop?

Perhaps you need to look at this? http://faq.cprogramming.com/cgi-bin/...&id=1043284385

Just add this to the end of main() and it should work:

Code:

while(getchar() != '\n');
getchar();

[edit] Noir has the same idea. [/edit]

> _getch()
getchar() is preferable if you don't mind hitting the enter key, because it is standard and _getch() is not.

Also is this "fflush( stdout );" just clearing the buffer?

Yes. Data printed to the screen is not guaranteed to be displayed if it doesn't end with a newline (I think), so one should use fflush() in that case. Files are different.

[edit] My connection must be a fraction of a second faster than Noir's. [/edit]

[edit=2] Even if you were using _getch(), don't forget to add the parentheses. [/edit]