Thread: CMD window closes when I try and read from file?

Hey all,

I'm trying to read from a file that the user has already named and written to correctly, but when I try to read it, the command prompt window closes. However, my code compiles successfully, and every tutorial I've looked at online is telling me to put in the same code as is in there already. Anyone got any ideas? Here's the code for reading the file:

Code:

void readFiles() {

    char choice;
    char line[80];
    int i = 0;
    printf("\nThe file \"%s\" was found. Would you like to load this file? (y/n)", filename);
    scanf("%c", &choice);
    
    if (choice == 'y' || choice == 'Y') {
    
        inFile = fopen(filename, "r");

        while(fgets(line, 80, inFile) != NULL) {
        
            gets(line);
            sscanf(line, "%s%d%d%d%d%d%d%d", theLeague[i].name, &theLeague[i].gamesPlayed, &theLeague[i].gamesDrawn, &theLeague[i].gamesLost, 
            &theLeague[i].goalsScored, &theLeague[i].goalsConceded, &theLeague[i].points);
            i++;
        } 
        
    }
    
    else {
    
        printf("\nYou chose not to load a file. Returning to menu...\n");
    } 
}

Code:

while(fgets(line, 80, inFile) != NULL) {
        
            gets(line);

you already loaded the strings on fgets(line, 80, inFile)
so why are you using gets again ?
and try to put
fflush(stdin);
getchar();
at the end of your source

Originally Posted by St0rM-MaN

Code:

while(fgets(line, 80, inFile) != NULL) {
        
            gets(line);

you already loaded the strings on fgets(line, 80, inFile)
so why are you using gets again ?

Oh, wasn't thinking

Originally Posted by St0rM-MaN

and try to put
fflush(stdin);
getchar();
at the end of your source

i've done that, as so:

Code:

while(fgets(line, 80, inFile) != NULL) {
        
            sscanf(line, "%s%d%d%d%d%d%d%d", theLeague[i].name, &theLeague[i].gamesPlayed, &theLeague[i].gamesDrawn, 
            &theLeague[i].gamesLost, &theLeague[i].goalsScored, &theLeague[i].goalsConceded, &theLeague[i].points);
            i++;
            fflush(stdin);
            getchar();
        }

but it's still crashing

Originally Posted by zacs7

DON'T fflush(stdin);
read the FAQ

How do you know 'i' is always going to be in-bounds with each iteration?
No need to flush the stream if your using fgets()...

I set it to 0 at the start of the method, so that it could address each item of the struct array from zero until the end.

I've changed the code to this for testing purposes, and it runs through, but doesn't scan the correct values in for some reason.

Code:

void readFiles() {

    char line[80];
    int i = 0;
    char fileReload[21];
        
    printf("\nEnter the name of the file you wish to load: ");
    scanf("%s", fileReload);
    
    printf("\n1\n");
            
        inFile = fopen(fileReload, "r");
        
        if(inFile == NULL) { 
           perror(NULL);
        }
        printf("\n2\n");
            
        while(fgets(line, 80, inFile) != NULL) {
        
        printf("\n3\n");
        
            sscanf(fileReload, "%s%d%d%d%d%d%d%d", theLeague[i].name, &theLeague[i].gamesPlayed, &theLeague[i].gamesDrawn,
          &theLeague[i].gamesLost, &theLeague[i].goalsScored, &theLeague[i].goalsConceded, &theLeague[i].points);
            i++;
            printf("%s", theLeague[i].name);
            
        }
    
    menu();
}

Code:

scanf("%s", fileReload);

Use fgets to read string. Dont use scanf. It would be more helpfull if you could show us your text file as well, whuch u are trying to scan.

Is the theLeague struct variable declared as global (which isn't a good idea by anyway)??

ssharish2005

Originally Posted by ssharish2005

Code:

scanf("%s", fileReload);

Use fgets to read string. Dont use scanf. It would be more helpfull if you could show us your text file as well, whuch u are trying to scan.

Is the theLeague struct variable declared as global (which isn't a good idea by anyway)??

ssharish2005

The text file is in the format, for example:

Liverpool 2 1 1 0 6 4 4
Everton 2 0 1 1 4 6 1

The struct is declared as global, I know it's bad and I will change it later, but for the time being I just need to get this working.