Thread: i need help with sorting an array

i solved the problem, and now i see its easy program actualy
here it is:

Code:

#include <stdio.h>
#include <iostream.h>

#define max       31

main()
{
      int n[max],brpoz=0,brneg,element,i,j,broj,save,t;
      
      do{
            printf("UNESI BROJ ELEMENATA NIZA: \n");
            scanf("%d",&broj);
            if(broj<1||broj>max) printf("GRESKA!!\n");
            }while(broj<1||broj>max);
            
            brneg=broj-1;
       ////////////////////////////////////////////////////////////////////////////////////
           for(i=0;i<broj;i++)
           {
              do{                                 
                   printf("%d.CLAN NIZA: ",i+1);
                   scanf("%d",&element);
                   if(element<-1000000||element>1000000) printf("GRESKA!!\n");
                   }while(element<-1000000||element>1000000);
              
              if(element>-1)
                {
                            n[brpoz]=element;
                            brpoz++;
                }
              else if(element<0) 
                { 
                            n[brneg]=element;
                            brneg--;
                }
              
           }
        ////////////////////////////////////////////////////////////////////////////////////   
           
           brpoz++;
           
         for(i=brneg+1,j=broj-1;i<=(brneg+broj)/2;i++,j--)
         {
                       t=n[i];
                       n[i]=n[j];
                       n[j]=t;
         }           
           
           
           
           
         for(i=0;i<broj;i++)
         {
                       printf("\n%d.CLAN: %d",i+1,n[i]);                             
         }
             
             printf("\n\n");
         system("pause");    
}

sorry, i had no time to translate all the texts from serbian into english, but anyway, you'll get the meaning of the code

Instead of writing:

Code:

if(element<-1000000||element>1000000) printf("GRESKA!!\n");
                   }while(element<-1000000||element>1000000);

use the minimum and maximum value defined in limits.h:

INT_MIN Minimum value for an object of type int -32767
INT_MAX Maximum value for an object of type int 32767

your code will look like:

Code:

if(element<INT_MIN||element>INT_MAX) printf("GRESKA!!\n");
                   }while(element<INT_MIN||element>INT_MAX);

And finally, I can tell you that this is completely useless since scanf() already truncates a number if its too big. You can't possibly write a number which is too large inside an int and then check if it's too big just to say that you couldn't have possibly done that.
That condition will never be met.

Originally Posted by zacs7

May I ask why it's in the window's forum?

Also don't use void main()!

Code:

int main(void) 
{

Read the FAQ.

Also use fgets() and sscanf() otherwise you run the risk of unwanted chars being left in the stream, read the FAQ on user input.

yes!! I NEVER use int main(void), as you can see in the code I posted

ps. thanks for your advice, they always come usefull

Originally Posted by Salem

Moved.

> #include <iostream.h>
This isn't a C header file, it's an OLD C++ header file (two reasons not to use it).

...i know. i just used it for testing my code - because of system("pause"). Its just that i had no time to remove unnecesary segments of the code, and to translate some parts like GRESKA (error), UNESI BROJ ELEMENATA (enter the nubmer of elements)....

Originally Posted by stubin87

...i know. i just used it for testing my code - because of system("pause").

Isn't system("pause") in stdlib?

Originally Posted by zacs7

Also don't use void main()!

Code:

int main(void) 
{

He didn't make it void. He simply said "main()," which means it returns an integer.

And the arguments of main are not void. This does not mean the same thing as empty parentheses. main() is okay, main(void) is not okay.

Originally Posted by dwks

Err . . . what? For a function declaration, () is the same as (void), in C and C++.

No it isn't.

Code:

void foo()
{
}

int main()
{
    foo(1, 2, 3, 4); /* NO PROBLEM HERE. */
    return 0;
}

If this were C++, you'd be right.

EDIT: I see you're making a distinction between definitions and prototypes. If there is no prior prototype, the definition IS the prototype. The reason that the following works:

Code:

void foo();
void foo(void)
{
}

Is purely for reasons of backward compatibility with old compilers that didn't have full prototype support.