Thread: Need HELP!

hi!

I'm having a problem on calling a function inside another function.
All my functions are in header files.

I've already called the menuInicial() function in the main() program, and it worked.
But since i tryed to call it in the menuLogin() function it's giving me this error:
"menuinicial.h(5) : error C2371: 'menuInicial' : redefinition; different basic types"

I'm using VS2005
Can anyone help me?

hey twomers, tnx for the fast reply.

I've done what you told me, but it's not working :-S

yes...lots o times.


I even added the #ifndef and #define in the main program.

Originally Posted by IndioDoido

All my functions are in header files.

This is generally something to avoid. That is, don't put function or data definitions in headers. Headers are a place for declarations, i.e. function prototypes, etc.

The header guards will only help you so far along -- with compiling, and then you'll bump into a linker issue if the header is included in multiple source files.

Look up all references to menuInicial. See if the prototype differs from how it is used. Or whether is called from a module that does not include the header, thus defaulting it to an int return type.

hi Dave...

I'm using header files so that my project can be more organized. :-S

The compile only shows the error when i call the menuInicial() in the menuLogin() function.
Besides that, the prog runs nicely.

Maybe you can find where the problem is.

Originally Posted by IndioDoido

I'm using header files so that my project can be more organized. :-S

That's the right idea, but you're doing it wrong. I was trying to let you in on this before you get used to doing it this way.

One of the issues is that you call a function without #include-ing the header, as I also mentioned; void menuLogin(void) impliticly declares your function returning an int.

You're running into these problems because you have code in header files. You will continue you have problems as long as you continue to do so.

Originally Posted by IndioDoido

"You're running into these problems because you have code in header files. You will continue you have problems as long as you continue to do so."

What do you mean by having code in the header files?

In a header file, just include function prototypes (and if you REALLY, REALLY HAVE TO, global variables).

Do not actually write the function out inside the .h file. Define it in the equivalent .c file.

So for an example:

Code:

/* swap.h */
#ifndef SWAP_DEF
#define SWAP_DEF

void swap(int *, int *);

#endif

Code:

/* swap.c */
#include "swap.h"

void swap(int *a, int *b)
{
	int temp = *a;
	*a = *b;
	*b = temp;
}