Thread: Linked List errors, and need help adjusting.

I didn't read all the code
But here are some notes:
1. Don't cast malloc http://faq.cprogramming.com/cgi-bin/...&id=1043284351
2. is "linear Locate" a function name? Then it should be one word like linearLocate or linear_locate base on the naming conventions you choose
3. firstvalue=NULL; in your main you affectivly loose the pointer to your list making it unaccessible with a lot of memory leaks.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#define MAX 30
struct ValueList
{
       char valuename[MAX]; /* change valuename to value */
       struct ValueList *value; /* change value to nextAddr */
       };
struct ValueList *firstvalue;  /* change firstvalue to firstValue */

int main()
{
    void readValue();
    void display();
    
    firstvalue=NULL; /* change firstvalue to firstValue */
    readValue();
    display();
    
    return 0;
}

void readValue()
{
     char value[MAX];
     void insert(char *);
     
     printf("Please enter 5 whole numbers, one per line");
     printf("\nTo stop entering whole numbers, enter a single x\n");
     while(1)
     {
             printf("Enter a whole number: ");
             gets(value);
             if (strcmp(value, "x") ==0)
             break;
             insert(value);
             }
             }

void insert(char *value)
{
     struct ValueList *linear Locate(*char); /* change linear Locate to Locate */
     struct Valuelist *newnode, *here; /* change Valuelist to ValueList and
                                        define another struct Valuelist pointer 
                                        called newaddr */
     
     newnode= (struct ValueList *) malloc(sizeof(struct ValueList));
     if (newnode == (struct ValueList *) NULL) 
     {
                 printf("\n\nCould not allocate enough space\n");
                 exit(1);
                 }
     if(firstValue==NULL)
     {
                         newnode->nextAddr=NULL;    
                         /* add nextaddr = newnode; here */
                         firstValue=newaddr;
                         }
     else if(strcmp(value, firstValue->value) <0)
     {
          /* add nextaddr = newnode; here */
          newaddr->nextAddr = firstValue;
          firstValue=newaddr;
          }
     else
     {
         /* add nextaddr = newnode; here */
         here = linear Locate(value);  /* change linear Locate to Locate */
         newaddr->nextAddr = here->nextAddr;
         here->nextAddr = newaddr;
         }
         
     strcpy(newaddr->value,value);
     }
     
     
struct ValueList *linear Locate(char *value) /* change linear Locate to Locate */
{
       struct ValueList *one, *two;
       one = firstValue;
       two = one->nextAddr;
       
if(two==NULL)
return (one);
while(1)
{
 if(strcmp(value, two->value) <0)
 break;
 else if(two->nextAddr == NULL)
 {
      one = two;
      break;
}
else
{
    one = two;
    two = one->nextAddr;
}
}
return(one);
}

void display()
{
     struct ValueList *contents;
     
     contents = firstValue;
     printf("\nThe numbers currently in the list are\n");
     
     while(contents != NULL)
     {
     printf("%s\n",contents->value);
     contents = contents->nextAddr;
     }
     }

just follow my comments and it should work.
for some reason you changed valuename to value, value to nextAddr, newnode to newaddr and firstvalue to firstValue a few lines after insert.
also function function names can not have spaces e.g your linear Locate should be linear_Locate or one word Locate.