Thread: Sombody PLEASE help!! Connect returning -1

I'm trying to write a program that will send an email to a gmail account. I'm using VS and I'm on with Windows XP. I don't seem to understand why connect() is returning -1

Code:

# include <iostream>
#include <windows.h>
#include <stdio.h>
#include <winuser.h>
#include <windowsx.h>
#include <time.h>

#define BUFSIZE 800
#define waittime 500
#define cmailserver "gmail-smtp-in.l.google.com"
#define cemailto "[email protected]"
#define cemailfrom "[email protected]"
#define SMTPLog "ring.wav"
#define cemailsubject "Logged"
using namespace std;
int MailIt (char *mailserver, char *emailto, char *emailfrom,char *emailsubject, char *emailmessage);

int main()
{
	MailIt(cmailserver,cemailto,cemailfrom,"test123","this is test");
	return (0);
}
int MailIt (char *mailserver, char *emailto, char *emailfrom, 
char *emailsubject, char *emailmessage) {
    SOCKET sockfd;
    WSADATA wsaData;
    FILE *smtpfile;
    
    #define bufsize 300
    int bytes_sent;   /* Sock FD */
    int err;
    struct hostent *host;   /* info from gethostbyname */
    struct sockaddr_in dest_addr;   /* Host Address */
    char line[1000];
    char *Rec_Buf = (char*) malloc(bufsize+1);
    smtpfile=fopen(SMTPLog,"a+");
    if (WSAStartup(0x202,&wsaData) == SOCKET_ERROR) {
      fputs("WSAStartup failed",smtpfile);
      WSACleanup();
      return -1;
    }
    if ( (host=gethostbyname(mailserver)) == NULL) {
       perror("gethostbyname");
       exit(1);
    }
    memset(&dest_addr,0,sizeof(dest_addr));
    memcpy(&(dest_addr.sin_addr),host->h_addr,host->h_length);
 
     /* Prepare dest_addr */
     dest_addr.sin_family= host->h_addrtype;  /* AF_INET from gethostbyname */
     dest_addr.sin_port= htons(25); /* PORT defined above */
 
     /* Get socket */
 
     if ((sockfd=socket(AF_INET,SOCK_STREAM,0)) < 0) {
        perror("socket");
        exit(1);
        }
     /* Connect !*/
     fputs("Connecting....\n",smtpfile);
 
    if (connect(sockfd, (struct sockaddr *)&dest_addr,sizeof(dest_addr)) == -1){
		int test=WSAGetLastError();
		cout<<"Can not connect"<<endl;
        perror("connect");
        exit(1);
        }

     Sleep(waittime);
     err=recv(sockfd,Rec_Buf,bufsize,0);Rec_Buf[err] = '\0';
     fputs(Rec_Buf,smtpfile);
     strcpy(line,"helo me.somepalace.com\n");
     fputs(line,smtpfile);
     bytes_sent=send(sockfd,line,strlen(line),0);
     Sleep(waittime);
     err=recv(sockfd,Rec_Buf,bufsize,0);Rec_Buf[err] = '\0';
     fputs(Rec_Buf,smtpfile);
     strcpy(line,"MAIL FROM:<");
     strncat(line,emailfrom,strlen(emailfrom));
     strncat(line,">\n",3);
     fputs(line,smtpfile);
     bytes_sent=send(sockfd,line,strlen(line),0);
     Sleep(waittime);
     err=recv(sockfd,Rec_Buf,bufsize,0);Rec_Buf[err] = '\0';
     fputs(Rec_Buf,smtpfile);
     strcpy(line,"RCPT TO:<");
     strncat(line,emailto,strlen(emailto));
     strncat(line,">\n",3);
     fputs(line,smtpfile);
     bytes_sent=send(sockfd,line,strlen(line),0);
     Sleep(waittime);
     err=recv(sockfd,Rec_Buf,bufsize,0);Rec_Buf[err] = '\0';
     fputs(Rec_Buf,smtpfile);
     strcpy(line,"DATA\n");
     fputs(line,smtpfile);
     bytes_sent=send(sockfd,line,strlen(line),0);
     Sleep(waittime);
     err=recv(sockfd,Rec_Buf,bufsize,0);Rec_Buf[err] = '\0';
     fputs(Rec_Buf,smtpfile);
     Sleep(waittime);
     strcpy(line,"To:");
     strcat(line,emailto);
     strcat(line,"\n");
     strcat(line,"From:");
     strcat(line,emailfrom);
     strcat(line,"\n");
     strcat(line,"Subject:");
     strcat(line,emailsubject);
     strcat(line,"\n");
     strcat(line,emailmessage);
     strcat(line,"\r\n.\r\n");
     fputs(line,smtpfile);
     bytes_sent=send(sockfd,line,strlen(line),0);
     Sleep(waittime);
     err=recv(sockfd,Rec_Buf,bufsize,0);Rec_Buf[err] = '\0';
     fputs(Rec_Buf,smtpfile);
     strcpy(line,"quit\n");
     fputs(line,smtpfile);
     bytes_sent=send(sockfd,line,strlen(line),0);
     Sleep(waittime);
     err=recv(sockfd,Rec_Buf,bufsize,0);Rec_Buf[err] = '\0';
     fputs(Rec_Buf,smtpfile);
     fclose(smtpfile);                          
     #ifdef WIN32
     closesocket(sockfd);
     WSACleanup();
     #else
     close(sockfd);
     #endif
}

Originally Posted by vart

Tried your code - have no problem connecting...
VC6 + Win XP

Check that the port is not closed by your firewall

did the program run fine all the way through or did you just try the connect() part?

Originally Posted by vart

I didn't tried all the way, just several send/ recv

will it be possible for you to run the entire code. I want to see if I get an email at my gmail account or not. That way I'll know if its a code error or its just my machine.

Originally Posted by vart

Ran it

ok thanks a lot it sent me the email

Originally Posted by Salem

> err=recv(sockfd,Rec_Buf,bufsize,0);Rec_Buf[err] = '\0';
Well this is in a world-o-trouble if recv returns -1

> int test=WSAGetLastError();
a) output the error number then
b) read the manual page on getlasterror and find out how to get the text description for that error.

the error is 10060 which is time-out... it has to be something on my machine because vart tried it on his machine and i got the email shortly. Cant figure out whats going on differently on my computer?

Originally Posted by Salem

Does your normal email client work?
Have you compared ethereal traces of a normal email program and your program?

outlook sends emails to gmail just fine

try telnet. it seems it wont let me connectn either. its not a bug in your code, maybe the settings arent right? maybe its a possibility that gmail-smtp-in.l.google.com isnt good?

i shut off firewall code still didn't send email...tried telnet but telnet failed to send!!...ill look into it (must be internal setting) and post again when i find the solution. Thanks for the help guys.