stuck in loop

[jms318]

i get my code to print columns and row at the number i enter at prompt put the program never breaks the loop. What am I doing wrong??

#include <stdio.h>

/* function main begins program execution */
int main()
{
   int row = 0; /* initialize row */
   int column;   /* define column */

   printf( "Enter a number of row to be printed\n" );
   scanf ( "%d", &row );


   while ( row >= 1 ) { /* loop until row < 1 */
      column = 1;       /* set column to 1 as interation begins */

      while ( column <= row ) {               /* loop 10 times */
         printf( "%s", row  ? "*": "*" ); /* output */
         column++; /* increment column */
      } /* end inner while */
	  printf( "\n" ); /* begin new output line */
	   
		 
   } /* end outer while */

   return 0; /* indicate program ended successfully */

} /* end function main */

[jms318]

ok here is my fix i was overlooking

#include <stdio.h>

/* function main begins program execution */
int main()
{
   int row; /* initialize row */
   int column;   /* define column */
   int x;

   printf( "Enter a number of row to be printed\n" );
   scanf ( "%d", &x );

   row = x;

   while ( row >= 1 ) { /* loop until row < 1 */
      column = 1;       /* set column to 1 as interation begins */

      while ( column <= row ) {               /* loop 10 times */
         printf( "%s", row  ? "*": "*" ); /* output */
         column++; /* increment column */
      } /* end inner while */
	  printf( "\n" ); /* begin new output line */
	  
	  x--;
	  if ( x < 1 ) break;
      
		  
		 
   } /* end outer while */

   return 0; /* indicate program ended successfully */

} /* end function main */

[vart]

column = 1;       /* set column to 1 as interation begins */

while ( column <= row ) {               /* loop 10 times */
	printf( "%s", row  ? "*": "*" ); /* output */
	column++; /* increment column */
} /* end inner while */

is equivalent to

for(column = 0; column < row; column++)
{
   printf("*");
}

And this

row = x;

while ( row >= 1 ) {      
	//SOME CODE HERE
	x--;
	if ( x < 1 ) break;
	
		  
	
} /* end outer while */

is equivalent to

for(row = x; row >= 1; row--)
{
	//SOME CODE HERE
}

Keep code simple - it is easier to find bugs in it - your bug is that you decrease x
But the loop should be on row...

If you made it by puporse than the second loop should be

for(row = x; x >= 1; x--)
{
	//SOME CODE HERE
}