bubble sort help.

Hi,
I just recently joined and i need some help with one of my assignments. please can you have a look and try to help thank you.

task:
Write an efficient bubble sort function optimised so as not to check data that is guaranteed to be in the correct position (i.e. each pass is shorter than the previous one). It should include code (as the naivesort program below does) that counts the number of comparisons performed storing the result in a call by reference variable to pass the information back to the calling function. Your program should print out a copy of the array before and after sorting. Include a test function that tests the code for a series of data sets containing from 1 to 100 pieces of randomly generated data. Modify the program given below.

Code:

// 	Sort an array of integers using naive sort: multiple 
//   passes with smaller values gradually bubbling up to the 
//   top. It works by repeated comparison of pairs of values
//   Count critical ops and save in a file for sorting array sizes up to 100


// For gcc compiler:
// gcc  -std=c99 naivesort.c -o naivesort
// even harder options -ansi -pedantic


#include <stdio.h>
#include <stdlib.h>
#include <time.h>

void naive_sort (int array [], int arraySize, int * count);
void swap (int * v1, int * v2);
void fill_array (int array [], int arraySize);
void print_array(int array[], int sizeOfData);

const int RANGE = 200; // random data used in range 0-199

int main()
  {
     const int arraySize = 100;
     int a[arraySize];
     FILE *resultsFile;
     
     // open the file for writing ("w")
     resultsFile = fopen("nsort.dat", "w");  

     if (resultsFile != NULL)      // file successfully opened
      {
         // seed the random number generator so it gives different
       // random numbers each time
       srand ( time (0) );


       // Table headings
       printf ("Found\t Data Size\t Comparisons Needed\n"  );
       
       //\t puts in a tab character, \n a new line
       fprintf (resultsFile, "Data Size\t Comparisons Needed\n"  );

       // Generate table for data of different sizes
       // giving number of comparisons each time

       for (int datasize = 1; datasize <= arraySize; datasize = datasize + 1)
		{
	  		int count = 0;  // number of comparisons this time

	  		fill_array(a, datasize);

	  		naive_sort (a, datasize, & count);

	  		// print results in a table
          	printf("%d  \t\t\t  %d\n", datasize, count);
          	fprintf(resultsFile, "%d  \t\t\t  %d\n", datasize, count);
		}

        print_array(a, arraySize); // check final version at least was sorted

       
     }
   else
      fprintf(resultsFile, "File not opened\n");

   fclose(resultsFile); return 0;
  }

Ok, first of all, here we answer questions, not just general pleas for help. What exactly is the problem ? Unexpected behaviour ? Not compiling ? General question on bubble sort ?

Be specific.

Oh, and by the way, chances are we'll have to look at your other functions too, (except probably print_array), so you may want to post them as well.

Hi,
Basically i need to make a bubble sort from that piece of code. As i have just started learning C. i would imagine that someone could help me, by making it a bubble sort. thank you.

http://www.google.com/search?q=bubble+sort

From what code i got up there. isnt it possible?.

What appears to be lacking from the code you posted is an attempt to implement a sort of any kind.

Welcome to the forum.

You've got some interesting phrases in the task description:
"efficient bubble sort": bubble sorts are *not* efficient
"not to check data that is guaranteed to be in the correct position": very odd idea that I can't wrap my head around. Maybe it's just me.

"naive" sort: never heard of "naive" sort.


If I understand this right, you're supposed to replace the naive sort function, with the bubble sort function. What part of the assignment has you stumped?

You need to get into this enough to ask some specific code or algorithm, questions.

Adak

Originally Posted by zeromx

From what code i got up there. isnt it possible?.

It is possible

replace the line

Code:

naive_sort (a, datasize, & count);

with the following

Code:

bubble_sort (a, datasize, & count);

Then - write the function bubble_sort as required by the assignment

Code:

// even harder options -ansi -pedantic

Um...

Originally Posted by zeromx

i would imagine that someone could help me, by making it a bubble sort. thank you.

What you don't understand is that NO ONE will do that unless you post a half-decent attempt at it. We won't do your homework for you...