Reducing the length of code

[Taka]

According to my teacher I shouldn't have a line of code longer than 80 characters. So if anyone could help me into breaking this up some other way that would be great.

while ((sortedListTrav->next != NULL) && (CompareNodes(empListTrav, sortedListTrav->next, sortField) >= 0))
            sortedListTrav = sortedListTrav->next;

I was thinking of changing it to an if statement but wasn't sure...

Thanks.

[nadroj]

i think this is more appropriate than an if statement.

the only reason your teacher would say that is to make the code more readable by other programmers. just use line breaks and/or whitespace in your code when a situation like this arises, such as:

while ((sortedListTrav->next != NULL) && 
       (CompareNodes(empListTrav, sortedListTrav->next, sortField) >= 0))
            sortedListTrav = sortedListTrav->next;

this still doesnt look the greatest but oh well. only other thing to do to make it shorter is to use shorter variable names, which is inappropriate so my opinion is its fine.

[Taka]

Ok... Thanks

[Cactus_Hugger]

while ((sortedListTrav->next != NULL) && 
       (CompareNodes(empListTrav, sortedListTrav->next, sortField) >= 0))
            sortedListTrav = sortedListTrav->next;

this still doesnt look the greatest but oh well. only other thing to do to make it shorter is to use shorter variable names, which is inappropriate so my opinion is its fine.

You can also remove those highlighted parentheses. Comparison operators (!=, ==, <=, >=, <, >) all have higher precedence than || and &&. Thus, you can say if(i >= 0 && i < 10) Of course, that's only four bytes, so I'd still break it into two lines. You can place whitespace (spaces, tabs, newlines) almost anywhere in code as long as it doesn't breakup function names, variable names, etc.

[dwks]

If all you're worried about is an 80 character line limit, then you can break the line in half where ever you can put spaces. "Whitespace" means newlines, tabs, spaces, etc; you can have whitespace almost where ever you want. (<ws> is where whitespace can go.)

if<ws>(<ws>x<ws>==<ws>7<ws>)<ws>{