Calling a function...

Code:

int main()
{
   char weight[6];
   int validity, break_flag;

   while(1)
   {
      break_flag = getinput (weight);
      if (break_flag == 1)
         break;
      validity = validate(weight);
      if (validity == 1)
         printf("%s - Too Heavy\n", weight);
      else
         printf("%s - Cleared\n", weight);
   }
   return 0;
}

I have the following code as my main function but I have just been told I'm not allowed to have a loop in my main. I tried moving the while loop to new function and using main to call that function (as below) but got the following errors:

weight.c: In function `loop':
weight.c:111: warning: control reaches end of non-void function
weight.c: In function `main':
weight.c:115: warning: statement with no effect

The program works fine before the changes.

Code:

int loop()
{
   char weight[6];
   int validity, break_flag;

   while(1)
   {
      break_flag = getinput (weight);
      if (break_flag == 1)
         break;
      validity = validate(weight);
      if (validity == 1)
         printf("%s - Too Heavy\n", weight);
      else
         printf("%s - Cleared\n", weight);
   }
}

int main()
{
   loop;

   return 0;
}

You forgot the parentheses.

Code:

int main()
{
   loop();

   return 0;
}

And as your function does not return anything, it should be declared as void loop();

When you call a function you need parenthesis after the identifier regardless of whether it takes arguments or not. What do you mean "not allowed to have a loop in my main". You mean as per your assignment or as a general programming rule?

According to my teacher it is a programming rule.

Thanks for your help.

Not a programming rule I've ever heard of. Your original code is better than your new code.

I guess it will just be a rule to pass the subject then I'll forget about it in that case lol

I'm with sly. There are times when certain functionality should be farmed off to functions but this just creates disjointed code for no real benefit.