Thread: Problem with a simple program

Alright, I just started teaching myself how to program C a couple days ago, so don't make fun of me too much!

Code:

#include <stdio.h>


//purpous is to have 4 numbers input and the average displayed


main()
{
	int a = 1;  //counter
	double b;   //numbers to be input
	double c = 0.0;   //total of all b
	char d;  //suffix to number

	while(a < 5)  
	{
		printf("Input your %d%c number: ",a,d==1?'st':(a==2?'nd':(a==3?'rd':'th')));   //input numbers
		scanf("%fl",&b);  //input numbers to be averaged
		c = c + b;  //add all the numbers up
		++a;  //tell program to go to next number
		if (a<5) continue;	//if not done inputting numbers, loops	
		printf("The average of the 4 numbers is %fl.",c/4);  //displays average of the sum of all 4 numbers inputted
	}
    
	return(0);
	
}

My problem is the program goes goofy when displaying the final averaged number. Does it have to do with the "Double"? Im getting a result a 0.0000001. Also it displays "t" at the end of each number when displaying which number to input.

Since when are 'st', 'nd', 'rd' and 'th' single characters?
= is an assignment.
== is an equality test.

Quzah.

Originally Posted by Salgat

I know about = and ==, not sure about how that applies here

Code:

printf("Input your %d%c number: ",a,d=1?'st':(a=2?'nd':(a=3?'rd':'th')));   //input numbers

Quzah.

Thanks! I was trying to apply a few things I was learning and reduce the amount of variables used, unfortunately I got a few things wrong. I know I may not be doing it all perfectly to the book, and I know C is a percise language, but was expirementing with some new operands and although that didn't work, I'm still wondering why its not outputting correctly.


Heres a revision for debugging purpouses.

Code:

#include <stdio.h>


//purpous is to have 4 numbers input and the average displayed


int main(void)
{
	double b;   //numbers to be input
	double c = 0.0;   //total of all b
	int a = 1;  //counter

	while(a < 5)  
	{
		printf("\nInput your %d number: ",a);   //input numbers
		scanf("%fl",&b);  //input numbers to be averaged
		printf("The number you input is: %fl",b);   //show your input
                c = c + b;  //add all the numbers up
		++a;  //tell program to go to next number
		if (a<5) continue;	//if not done inputting numbers, loops	
		printf("The average of the 4 numbers is %.2fl.",c/4);  //displays average of the sum of all 4 numbers inputted




	}
    
	return(0);
	
}

I just want to know, why isnt it reading my double variable "b" correctly.

Code:

scanf("%fl",&b);  //input numbers to be averaged

Try spelling %lf correctly. And for printf, just use %f.

Oh ya! Haha, thanks (I would use floats, and a more simple setup, but like I said, trying out different things);

(ended up finishing it, thanks guys )

Code:

#include <stdio.h>
//Title: Min, Max, and Average
//Purpose: Is to have a given amount of numbers input and the average displayed
//Creator: Austin Salgat



main()
{
    int a = 1;  //counter
   	int d;   //amount of #s averaged
	double b;   //current # inputted
	double c = 0.0;   //total of all b
	double e = 0.0;   //max #
	double f = 999.999;   //min #

	printf("**************************************\n***   Find Min, Max, and Average   ***\n***    Created by Austin Salgat    ***\n**************************************");
	printf("\n\nHow many numbers do you wish to put into this average?: ");
    scanf("%d",&d);  //input how many numbers to average

	while(a <= d)  
	{
  	    printf("\nInput number %d: ",a);   //input numbers
		scanf("%lf",&b);  //input numbers to be averaged
        e = (b>e) ? b : e;   //input new max
		f = (b<f) ? b : f;  //input new min
        c = c + b;  //add all the numbers up
		
        printf("\nThe average of the %d number%c is %.2lf.",a,a==1?' ':'s',c/a);  //displays average of the sum of all 4 numbers inputted
		printf("\nThe max is %.2lf and the min is %.2lf.\n",e,f);  //displays min and max
		++a;  //tell program to go to next number
	}
    
    printf("\n\n\nTo exit this program, simply type a letter and press enter!: ");
    scanf("%d",a);
	return(0);
	
}