Pipe problem, popen(), pipe().

Hello.
I have to write program which reads a correct linux pipe for example:
program1 | program2 | program3 | program 4
and proceeds with pipes.
I'm doing something like this:
reading input.
then i'm getting first command (i'm looking for the first '|'). Then I'm forking function with a string without begining (in the example above, im forking with string "program2 | program3 | program 4" and then in the parent i'm executing "program 1" with popen(). Then i'm reading the data from this pipe (what program1 returns) and then seding it to the child. Child recieves it. And here is my problem. Child has to run "program2" with everything what program1 sent. But I don't really know how to do this. I'm doing something like this: I have a string in which I have a "program2" + data which child received from parent and run it with popen(). But it doesn't seem to work like with an example:
cat file | grep something.
Is there any universal way to running programX with the data recieved from the parent?
Regards,
apacz

My guess would be to parse the command line and find that there are 'n' commands, and 'n-1' pipes.
Create 'n-1' pipes using the pipe() system call, and create 'n' child processes using the fork() and execl() system calls.

Hello,
I coded something like this:

Code:

#include <stdio.h>
#include <string.h>

#define MAXLEN 1000    
#define BUFSIZE 20     

int main()
{
        int     i,
                j,
                rec,
                fd[2];
        char    tmp,
                input_pipe[MAXLEN],
                command[MAXLEN],
                buf[BUFSIZE];
        i = 0;
        scanf("%c", &tmp);
        while(tmp != '\n')
        {
                input_pipe[i] = tmp;
                i++;
                scanf("%c", &tmp);
        }
        input_pipe[i] = 0;

        pipe(fd);

        memset(command, 0, MAXLEN);
        j = 0;

        for(i = 0; i < strlen(input_pipe); i++)
        {
                if(input_pipe[i] != '|')
                {
                        command[j] = input_pipe[i];
                        j++;
                }
                else
                {
                        command[j] = 0;

                        if(fork() == 0)
                        {
                                dup2(fd[0], 0);
                                dup2(fd[1], 1);
                                system(command);                        
                        }

                        memset(command, 0, MAXLEN);
                        j = 0;
                }
        }
        if(fork() == 0)
        {
                dup2(fd[0], 0);
                dup2(fd[1], 1);
                system(command);
        }

        while((rec = read(fd[0], buf, BUFSIZE)) > 0)
                write(1, buf, rec);


        return  0;
}

But it only work when I put no-pipe command like "cat file" but anyways program doesn't quit then. If I put command with a pipe it only executes what is before "|". Can anyone tell me what I'm doing wrong?
--
Regards,
apacz

The first thing I would do is clean up all the compiler warnings. You're missing some pretty important header files. If you're not seing any compiler warnings then make sure you compile with -Wall.

Thanks, you are right. I added:
#include <unistd.h>
#include <stdlib.h>
but it doesn't solve the main problem.
Regards,
apacz

I've also added wait() in parents' code:

Code:

#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <stdlib.h>
#include <sys/wait.h>

#define MAXLEN 1000     /* Maksymalna dlugosc input_pipeu */
#define BUFSIZE 20      /* Rozmiar uzywanych buforow */

int main()
{
        int     i,
                j,
                rec,
                status,
                fd[2];
        char    tmp,
                input_pipe[MAXLEN],
                command[MAXLEN],
                buf[BUFSIZE];
        i = 0;
        scanf("%c", &tmp);
        while(tmp != '\n')
        {
                input_pipe[i] = tmp;
                i++;
                scanf("%c", &tmp);
        }
        input_pipe[i] = 0;

        pipe(fd);

        memset(command, 0, MAXLEN);
        j = 0;

        for(i = 0; i < strlen(input_pipe); i++)
        {
                printf("%d\n", i);
                if(input_pipe[i] != '|')
                {
                        command[j] = input_pipe[i];
                        j++;
                }
                else
                {
                        command[j] = 0;

                        /* printf("::%s\n", command);  */                       
                        if(fork() == 0)
                        {
                                if(dup2(fd[0], 0) == -1)
                                        printf("dup2() error1\n");
                                if(dup2(fd[1], 1) == -1)
                                        printf("dup2() error2\n");
                                system(command);
                                exit(5);
                        }
                        else
                        {
                                wait(&status);
                                memset(command, 0, MAXLEN);
                                j = 0;
                        }
                }
        }
        if(fork() == 0)
        {
                dup2(fd[0], 0);
                dup2(fd[1], 1);
                system(command);
                exit(6);
        }
        else
        {
                wait(&status);
                while((rec = read(fd[0], buf, BUFSIZE)) > 0)
                        write(1, buf, rec);
        }


        return  0;
}

But it's still the same :/

Hello,
I have next version of my program :

Code:

#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <stdlib.h>
#include <sys/wait.h>

#define MAXLEN 1000     /* Maksymalna dlugosc input_pipeu */
#define BUFSIZE 20      /* Rozmiar uzywanych buforow */


int main()
{
        int     i,
                j,
                rec,
                status,
                d = 0,
                fd[2];
        char    tmp,
                input_pipe[MAXLEN],
                command[MAXLEN],
                buf[BUFSIZE];
        i = 0;
        scanf("%c", &tmp);
        while(tmp != '\n')
        {
                input_pipe[i] = tmp;
                i++;
                scanf("%c", &tmp);
        }
        input_pipe[i] = 0;

        pipe(fd);

        memset(command, 0, MAXLEN);
        j = 0;

        for(i = 0; i < strlen(input_pipe); i++)
        {
                if(input_pipe[i] != '|')
                {
                        command[j] = input_pipe[i];
                        j++;
                }
                else
                {
                        command[j] = 0;                        
                        if(vfork() == 0)
                        {
                                dup2(fd[0], 0);
                                dup2(fd[1], 1);
                                system(command);
                        }
                        else
                        {
                                memset(command, 0, MAXLEN);

                                j = 0;
                        }
                }
        }
        if(fork() == 0)
        {
                dup2(fd[0], 0);
                dup2(fd[1], 1);
                system(command);
        }
        else
        {
                wait(&status);
                close(fd[1]);
                while((rec = read(fd[0], buf, BUFSIZE)) > 0)
                        write(1, buf, rec);
                close(fd[0]);
        }


        return  0;
}

But it hangs on the second dup2() in the child code in for() loop... I have no clue why. Both dup2()s outside the for() works fine. Can anyone help?
Regards,
apacz

Probably, but not till tomorrow when I'm back at my linux box..