Why is this code snippet refusing to work ?

**saraghav** · 05-27-2006

Code:

#include <stdio.h>

main()
{
	FILE *fp;

	fp=fopen("Welcome.txt","r+");

	char c;

	while((c=fgetc(fp))!=EOF)
	{
		if((c>='a')&&(c<='z'))
			c -= 32;
		fputc(c,stdout);
	}

	fclose(fp);
}

When I compile this code,it works perfectly, but when I execute it the following error message is displayed. Can anyone explain why ?

Code:

Exception 0xc0000005
Segment Violation
Address: 0x73da15ce

**Ken Fitlike** · 05-27-2006

FAQ > Explanations of... > Definition of EOF and how to use it effectively

Originally Posted by kermi3

Welcome to the boards. If you haven't already done so then please take some time to familiarise yourself with the faq:
http://faq.cprogramming.com/cgi-bin/smartfaq.cgi

Make sure you have a look at the the posting guidelines:
http://cboard.cprogramming.com/annou...ouncementid=51
Following the rules will ensure you get a prompt answer to your question.

Remember, too, that the board has a search facility, a link is at the top of your screen:
http://cboard.cprogramming.com/search.php
It will often get you a quicker answer to your questions than waiting for a response to one you have posted.

If you have any questions about this you may ask or you can contact one of our forum leaders:

http://cboard.cprogramming.com/showgroups.php

**dwks** · 05-27-2006

It's highly likely that Welcome.txt doesn't exist.

Code:

		if((c>='a')&&(c<='z'))
			c -= 32;

Are you trying to convert letters to uppercase here? If so, look into toupper() in <ctype.h>.

**saraghav** · 06-01-2006

Actually, I created the file Welcome.txt with the text :

Code:

hello

I can't understand the error message ( see the first topic ).

**Salem** · 06-01-2006

> fp=fopen("Welcome.txt","r+");
Try

Code:

fp=fopen("Welcome.txt","r+");
if ( fp == NULL ) {
  printf( "Could not open file\n" );
  perror( "Error is" );
}

> char c;
Should be
int c;

It should also be before the fopen() call, since C doesn't have mixed declarations and statements.

Thread: Why is this code snippet refusing to work ?

Thread Tools

Search Thread

Display

Why is this code snippet refusing to work ?

Similar Threads

A funny code snippet of "sizeof()"

code wont work

Binary Search Trees Part III

<< !! Posting Code? Read this First !! >>