Thread: need help!!!!

hi there i want to make a console application which the user can pick whether a calculator or a temp converter but the problem is it wont compile at all need help......

Code:

#include <stdio.h>
#include <conio.h>



int main(void)

{

    int menu, menu1, numb1, numb2, total;
    int valid = 0;
    while(valid == 0){  
    printf("ENTER CHOICE\n");
    puts("1 = calculator");
    puts("2 = TEMP converter");
    scanf("%d", &menu);
    if((menu == 1) || (menu == 2))
    valid = 0;
    
    else{
            printf("****GOODBYE YOU PICK A WRONG CHOICE*****\n");
                getch();
                return 0;
            }
            if(menu == 1)
            {
                printf("ENTER IN FIRST NUMBER\n");
                scanf("%d", &numb1);
                puts("enter second number");
                scanf("%d", &numb2);
                puts("Enter in choice");
                puts("1 = addition");
                puts("2 = subtraction");
                scanf("%d", &menu);
                switch(menu){
                    case 1: total = numb1 + numb2; break;
                    case 2: total = numb1 - numb2; break;
                    default: printf("sorry wrong choice\n");
            }    
                printf("%d\n", total);
               
            {
            getch();               
            return 0;
        }
    }
    else if(menu ==2)
    {
        puts("enter temp");
        scanf("%d", &numb1);
        puts("enter in choice");
        puts("1 = fahr to celsius");
        puts("2 = celsius to fahr");
        scanf("%d", &menu1);
        switch(menu1){
            case 1: total = (5.0/9.0)*(numb1-32); break;
            case 2: total = (9.0/5.0)*numb1+32; break;
            default: printf("Wrong selection\n");
            }
            
            printf("%d\n", total);
            getch();
            return 0;
    }    
       }    
                                                                                                            
    getch();
    return 0;
  
}

that's the code[not yet finish]////// help needed...

Generally if your program won't compile, it tells you why. These are known as "error messages". Also pay attention to "compiler warnings". If you don't have any of either, turn them on in your IDE, or use the appropriate flags for your compiler.

Here's a tip: No one wants to copy your program to a file, save it, and run it through their compiler, just to get the warnings and errors you neglected to include.

If you get a huge list of hundreds of errors and warnings, start with the first one. Look at the line number, or those lines around that point, and fix that problem. Once you're done with that one, compile again. Repeat until done.


Quzah.

>> case 1: total = (5.0/9.0)*(numb1-32); break;
>> case 1: total = (9.0/5.0)*numb1+32; break;

See anything wrong there? also, you have a brace mismatch -
need to add one more brace at the end of the program, which
would be easier to fix if you had used consistent indentation.
Stop using just main - its int main for a reason - this is my second
time telling you this today

Also, there are better alternatives to system ("pause") -
check out the first one on this link

sorry for that(,'') i didn't see it but anyway thanks and for the link thanks also btw i didn't learned system("pause") from K and R i learned it from other tutorials but i forgot the link and also the warnings i haven't noticed that i picked c++ project instead c....thanks......
Richie T, Quantum1024 and quzah thanks i manage to fix the problem.....

You can restructure your code a bit:

Code:

if(1) DO THIS;
else if(2) DO THAT;
else PRINT ERROR;