Help with strings and numbers ;[

Hello, hum... I posted it in the wrong forum... so posting it here now...
Here is the deal: I must do a program that read a name, and 3 notes (rating ? Score ? =p) and made a average note of these 3...] And if you writes END ("fim" in this case) it should stop...

Code:

---

#include <stdio.h>
#include <conio.h>
#include <string.h>

int main ()
{
float NOTA[3][4],MEDIA,SOMA;
int CONTN,CONTY,CONTA;
char NOME[3][31];
SOMA = 0;
CONTA = 0;
for (CONTN=0;CONTN<3;CONTN++)
{
printf ("\nDigite o nome:");
gets (NOME[CONTN]);
CONTA = CONTA++;
if (!strcmp(NOME[CONTN], "fim"))
 break;
for (CONTY=0;CONTY<3;CONTY++)
{
printf ("\nNota %d:",CONTY);
scanf ("%f",&NOTA[CONTN][CONTY]);
SOMA = SOMA+NOTA[CONTN][CONTY];
}
MEDIA = SOMA/3;
NOTA[CONTN][3] = MEDIA;
}
printf ("Nome, Media");
for (CONTN=0;CONTN<CONTA;CONTN++)
{
printf ("\n%s %.2f",NOME[CONTN],NOTA[CONTN][3]);
}
getch();
}

---

The first name apparently goes ok... after that it goes wrong =o

BTW: I'm just testing with 3 names first...
BTW²: I'm using portugues words.. (Nome = Name) (Media = Average)

Anyone have any ideia that can help-me ? =p What is wrong ? :confused: :confused: :confused:

Thanks... =]

Your code is hard to read. It's pretty conventional to use tabs for things like if statements, loops, etc:
example:

Code:

---

for (i = 0; i < 10; ++i) {
    scanf("%s", str);
}

---

You'd probably have a better chance at getting help if you indented and it'd make it easy for you in the future to take a look at your own code.

It seems you needed to refresh the input buffer. I did it with

fflush(stdin)

I made some other changes because it wasn't running correctly. SOMA needed to be reinitialized to zero within the loop.. Also you were not incrementing CONTA correctly. It should be CONTA++ instead of CONTA = CONTA++.

Comments are in the code where the errors are.

Code:

---

#include <stdio.h>
#include <conio.h>
#include <string.h>

int main ()
{
        float NOTA[3][4],MEDIA,SOMA;
        int CONTN,CONTY,CONTA;
        char NOME[3][31];
       
        CONTA = 0;

        for (CONTN=0;CONTN<3;CONTN++)
        {

                // SOMA needs to be
                // reinitialized to zero

                SOMA = 0;
                printf ("\nDigite o nome:");

                // Input buffer needed to be
                // flushed it seems

                fflush(stdin);
                gets (NOME[CONTN]);

                //CONTA = CONTA++;
                CONTA++;

                if (!strcmp(NOME[CONTN], "fim"))
                        break;

                for (CONTY=0;CONTY<3;CONTY++)
                {
                        printf ("\nNota %d:",CONTY);
                        fflush(stdin);
                        scanf ("%f",&NOTA[CONTN][CONTY]);
                        SOMA = SOMA+NOTA[CONTN][CONTY];
                }

                MEDIA = SOMA/3;
                NOTA[CONTN][3] = MEDIA;

        }

        printf ("Nome, Media");
        for (CONTN=0;CONTN<CONTA;CONTN++)
        {
                printf ("\n%s %.2f",NOME[CONTN],NOTA[CONTN][3]);
        }
        _getch();
        return 0;
}

---

FAQ

FAQ > How do I... (Level 1) > Get a line of text from the user/keyboard (C)
FAQ > Explanations of... > Why fflush(stdin) is wrong
FAQ > How do I... (Level 1) > Flush the input buffer
FAQ > How do I... (Level 1) > How do I get my program to wait for a keypress?

http://c-faq.com/stdio/getsvsfgets.html
http://c-faq.com/stdio/stdinflush.html

=o wow... Thanks silk.odyssey ... I love you man :D

I didnt about that flush thing =o Very nice...

Thanks a lot :D

Seems that someone else has been poisoned by fflush(stdin) and gets()
Oh well, time will surely tell....

Quote:

---

Originally Posted by majindox

=o wow... Thanks silk.odyssey ... I love you man :D

---

=( wow... Did you even look at Dave's post?

Quote:

---

Originally Posted by majindox

I didnt about that flush thing =o Very nice...

---

and dangerous... and wrong. Fergitaboutit now!!!!

My apologies for the fflush thing, I wasn't aware of the problem. Any good solutions?

A couple. Your compiler might have a fuction that really cleans the input buffer, but you have to find it first, and it's not portable. It's probably in stdio.h.

A more portable way to do this is a while loop with getchar() that eats everything up. It doesn't work as well as your compiler's function but it gets the job done.

Code:

---

int c;
while((c=getchar()) != '\n' && c != EOF);

---

It's in the FAQ.

I've found that solution. The only problem is that it requires pressing enter when the buffer doesn't need to be flushed. Is there a way of determining before hand if a flush is necesary? In the mean time I would try to find out if the compilers I have support it. I have using msvc2005 and pellesc by the way if anyone knows a function that would do the job.

I like to use a careful combination of fgets and the flushing
method just mentioned - fgets leaves characters in the buffer
if the sting entered is too large. The natural thing would be to
flush these, but the getchar method will cause a user to have to
press enter if there was no data to flush. My solution is this
function which I coded:

Code:

---

void strget (char *str, int size, FILE *ip)
{
        char *pointer;
        int clear;

        fgets (str, size, ip);

        if ((pointer = strchr(str, '\n')) != NULL)        /*if newline is present*/
                *pointer = '\0';                        /*change it to \0*/

        /*otherwise there is at least one character in the buffer, so flush it*/
        else while ((clear = getchar ()) != '\n' && (clear != EOF));
}

---

[edit]
oops, forgot to mention this needs string.h for strchr, although
you could write some code to get around it I'm sure. Also,
see my sig, it appears that you have missed what people such
as Salem and Dave_Sinkula are saying about gets()

Thanks a lot. :)