Thread: Need help with "if" statements

Originally Posted by citizen

Code:

 printf("Enter a value:\n"); 
   scanf("%d",&a);
   { // just delete this brace. It's not necessary.

Still wouldn't fix it. They're missing the one for main.


Quzah.

Running the most recent post through a beautifier, this is what you have:

Code:

#include <stdio.h>
#include <string.h>
int main() 
{
   int a;
   char name[1];
   int d=1; 
   printf ("%s","Welcome to Harry's Vending Machine\n");
   printf("Enter a value:\n"); 
   scanf("%d",&a);
   {  
      if ( a >= 1 )
      {
         printf ("\nPress 1 for 7 up\n");
         printf ("\nPress 2 for Coca Cola\n");
         printf ("\nPress 3 for Pepsi\n");
         printf ("\nPress 4 for Bottled Water\n");
         printf ("\nPress 5 for Dr. Pepper\n");
         scanf ("%d", 5);
         printf("Thank you for your purchase\n");
         printf ("\nEnjoy your refreshing drink and don't forget your change\n");       
      }
      else
      {
         printf("Please insert correct amount\n");
         scanf("%d", &a); 
      }

Following good indentation habits is for the new to help write good code.

[edit]FAQ > How do I... (Level 1) > How do I get a number from the user (C)

Code:

/* aa.c */



#include <stdio.h>
#include <string.h>
int main() 
{   
  int a,d ;
  char name[1];
   d=1; 
   printf ("%s","Welcome to Harry's Vending Machine\n");
   printf("Enter a value:\n"); 
   

         
    printf ("\nPress 1 for 7 up\n");
    printf ("\nPress 2 for Coca Cola\n");
    printf ("\nPress 3 for Pepsi\n");
    printf ("\nPress 4 for Bottled Water\n");
    printf ("\nPress 5 for Dr. Pepper\n");
    scanf ("%d", &a);


     
   if(a >= 1) 
{   

    printf("Thank you for your purchase\n");
    printf ("\nEnjoy your refreshing drink and don't forget your change\n");       
  }  
   else {
   printf("Please insert correct amount\n");
   scanf("%d", &a); 
  }
}

do not need d
do not need name[]
menu before enter a value
prog not done are you going to do something with each diff selection?

anyway

Code:

if (test;) { statement; }
 else if (test;) {statement;}

Originally Posted by Harryt123

Code:

/* aa.c */
#include <stdio.h>
#include <string.h>
int main() 
{   
  int a;
  char name[1]; /* An array of 1 item is pointless. */
   printf ("Welcome to Harry's Vending Machine\n");
   printf("Enter a value:\n"); /* Shouldn't you display the menu before asking for a choice? */
   {
   check: if ('a' >=1) /* If the letter (character) 'a' is greater than or equal to one... */
    /* 'check:' is a goto lable, which you never use. */
    scanf('a'==0); /* Did you even try compiling your code? */
    printf ("\nPress 1 for 7 up\n");
    printf ("\nPress 2 for Coca Cola\n");
    printf ("\nPress 3 for Pepsi\n");
    printf ("\nPress 4 for Bottled Water\n");
    printf ("\nPress 5 for Dr. Pepper\n");
    scanf ('a'==0); /* 'a' is the character constant for the letter a, not your variable. */
    if('a' >= 1) /* Same problem here... */
  {
    printf("Thank you for your purchase\n");
    printf ("\nEnjoy your refreshing drink and don't forget your change\n");       
  }
   else {
   printf("Please insert correct amount\n");
    while ( a < 1 );   /* Here is the only time you're comparing your variable a correctly. */
}

Commented. However there are a few more points, such as 'name' never being used, and the variable a being used uninitialized. Things like that. You need to read your chapter on using scanf over again, and learn how it works.


Quzah.