Thread: Infinite looping

Hello all. I've encountered a problem with some code I'm using and I was looking for some help. The code is:

Code:

temp = 0;
while (temp < 1 || temp > 7) {
    system("CLS");
    printf("Race selection\n--------------\n");
    printf("1. Human\n2. Dwarf\n3. Elf\n4. Gnome\n"
        "5. Half-Elf\n6. Half-Orc\n7. Halfling\n");
    printf("Race: ");
    scanf("%i", &temp);
}

My problem is that if the user enters a letter (I tested 'a'), then the program loops infinitely. This is not the case if the user enters numbers, as far as I can see. When numbers are entered the form re-appears as expected.

Any help is appreciated

Originally Posted by InvertedSaint

Hello all. I've encountered a problem with some code I'm using and I was looking for some help. The code is:

Code:

temp = 0;
while (temp < 1 || temp > 7) {
    system("CLS");
    printf("Race selection\n--------------\n");
    printf("1. Human\n2. Dwarf\n3. Elf\n4. Gnome\n"
        "5. Half-Elf\n6. Half-Orc\n7. Halfling\n");
    printf("Race: ");
    scanf("%i", &temp);
    fflush( stdin );
}

My problem is that if the user enters a letter (I tested 'a'), then the program loops infinitely. This is not the case if the user enters numbers, as far as I can see. When numbers are entered the form re-appears as expected.

Any help is appreciated

You need to flush the input buffer using fflush.

It works perfectly Thank you for your help

I'll go read up on what fflush is doing, now

No worries. And I noticed you are using %i in your scanf. If you're scanning for integers, that should be %d. Unless %i is an old implementation?

Originally Posted by Salem

> Unless %i is an old implementation?
Perfectly valid to use this instead of %d.

Ahh ok, I have never seen %i before.