clueless file access problem

so for some reason my program likes to tell me "Could not open file.". it shouldn't be doing this, at least from what i can tell...here's my code:

Code:

void SearchFiles(HWND hwnd, char *keywords)
{
     FILE *fileptr, *xFileptr;
     char file[255] = {0}, data[255] = {0};
     
     if((fileptr = fopen("dirlist.sby", "r")) == NULL)
     {
         MessageBox(NULL, "There was an error retrieving the directory listing.\n",
           "Error!", MB_OK | MB_ICONEXCLAMATION);
     }
     else
     {
         while(fgets(file, 255, fileptr) != '\0')
         {
             if((xFileptr = fopen(file, "r")) == NULL)
             {
                 MessageBox(NULL, "Could not open file.\n", "Error!", MB_OK | MB_ICONEXCLAMATION);
             }
             else
             {
                 while(fgets(data, 255, xFileptr) != '\0')
                 {
                     if(strstr(data, keywords) != NULL)
                     {
                         SendMessage(GetDlgItem(hwnd, ID_LISTOUT), LB_ADDSTRING, 0, (LPARAM)file);
                     }
                 }
             }
             fclose(xFileptr);
         }
         fclose(fileptr);
     }
}

?? what am i doing wrong ?? i tried the debug function of Dev-C++ but it just freezes. everytime i run this, after telling me it can't open the file windows asks me to send them a report of my program crashing. =\


hah...so the problem was the method in which i was reading from the file. the fgets() function for some reason was messing it up. after adding/using this function:

Code:

int fixgets(char input_array[], int length, FILE *file_name)
{
   register int position=0;

   if (fgets(input_array,length,file_name) != NULL)
     {
     while(input_array[position] != 0)
	  {              if (input_array[position] < 32) input_array[position]=0;
	  else ++position;
	  }
     }
   /* The length of the string is returned. */
   return position;
}

it worked :]

I'm thinking you have a list of filenames, one filename per line. If you do, and you're using fgets() to read filenames one by one, then fgets() is likely storing a newline ('\n') to the end of your input, causing your fopen() to fail. (You're trying to open "myfile.txt\n") You sort of correct this with your fixgets function because you wipe the newline.

Also, in checking the return type of fgets(), I personally say != NULL as opposed to != '\0'.

See fgets().

Just check if the last character in each filename is '\n', if so change it to '\0' and all C functions will treat it as if though it never existed.

doing != NULL rather than != 0 or != '\0' gives the warning of comparison between a pointer and integer. the others do not.

thx tho

Code:

#include <stdio.h>

int main()
{
	char text[10];
	
	if(fgets(text, 5, stdin) == NULL) return 1;
	
	return 0;
}

Code:

$ gcc -Wall -o fgets.exe fgets.c
$

No errors. fgets() returns a pointer to a char. Thus '\0' (A character, though my gcc will not warn me as long as it's '\0'. If it's something like 'a', I get invalid comparision between a pointer and a integer. (fgets() and 'a', respectively))

Interesting you should get that error, as you use NULL to check the return of strstr(), which is the same type as fgets(). There is also a FAQ Article on this.

> doing != NULL rather than != 0 or != '\0' gives the warning of comparison between a pointer and integer
Try including all the correct header files then.

Originally Posted by Salem

> doing != NULL rather than != 0 or != '\0' gives the warning of comparison between a pointer and integer
Try including all the correct header files then.

and those would be?


adding -Wall to the compiler made the warnings go away


although i found that using fgets to control the loop it was only reading the first line of each file as there was white space between the first line and the next line for some files. this was stopping the loop.