linked list

Hi,
I have two problems:
please can someone give me an algorithm that would help me to understand how to put words ( read from a file) in alphabetical order using a linked list. I just dont get it!!

Also, The words that I need to input is a real text.
but There is punctuation (",", "!",".") that I need to skip in order to continue inputting words.
I know that I can do

Code:

 fscanf(fptr,"  [^,], ", words)

to skip the comma. but how can I do all the 3 punctuations in once?

Thank you for your help and time
B.

You can list whatever characters you're interested in in the scan set.

Originally Posted by braddy

Hi,
I have two problems:
please can someone give me an algorithm that would help me to understand how to put words ( read from a file) in alphabetical order using a linked list. I just dont get it!!

You need to be able to start by getting the words and inserting them into the list unsorted and then worry about sorting them. Can you do that?

Originally Posted by hk_mp5kpdw

You need to be able to start by getting the words and inserting them into the list unsorted and then worry about sorting them. Can you do that?

I try but it does not work!
This is what I did. I have 2 main problem:
1- in create function I have a problem read the word by word and then continue when one line is done.
2- the way I wrote create does not work. it crashes

this is my template and my function create that is suppose to create a likned list as I read the text.

Code:

typedef struct wordnode {
        char *word;
        int length;
        int freq;
        struct wordnode *next}   WORD;


void create(WORD *record)    
  {  char temp[30]; 
      int k;
      FILE *fin;
      fin=fopen("cp50610.dat","r");
      fscanf(fin," %[^ ,.;'?!]",temp); 
      k = strlen(temp)+1; /*use for the future*/
      record->word=malloc(k*sizeof(char)); 
      strcpy(record->word,temp); 
     record->next = malloc(sizeof(WORD));
     create(record->next); 
     fclose(fin);
     } /*end of create */

Please can someone help me?
thank you
B

Your function might work better if you had something like:

Code:

void create(WORD *record, FILE *f)

And then you don't just keep opening and opening and opening and opening the file. It never closes because it is infinite recursion. You should make a base case for it to stop.

I might be having a brain fart, but I'm drawing a blank right about here

Code:

record->word=malloc(k*sizeof(char)); 
      strcpy(record->word,temp); 
     record->next = malloc(sizeof(WORD));

If you allocate memory to record->word, don't you like need to allocate memory large enough to access the structure that access record->next?

I don't think so. The function operates on an already allocated WORD node and then allocates space for the next one and calls itself recursively. This is also an issue, when you initially call the function, your head node should be previously allocated, and also in your base case you should set the end of the list making record->next = NULL;

Okay. Maybe this is just personal bias, but I personally don't care for recursion in linked lists. I think recursive functions should be confined to the realm of Binary Trees. I just prefer the route of setting up a head node, pass it to the function, then doing a bunch of calls to malloc() (via the while loop) to produce the nodes on a linked list.

Originally Posted by Tonto

I don't think so. The function operates on an already allocated WORD node and then allocates space for the next one and calls itself recursively. This is also an issue, when you initially call the function, your head node should be previously allocated, and also in your base case you should set the end of the list making record->next = NULL;

I have some issue in the display. I have made the changes but when I execute, the output file is blank, even the header output does not print.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

typedef struct wordnode {
        char *word;
        int length;
        int freq;
        struct wordnode *next}   WORD;

main()
{
      FILE *fin,*fout;
     WORD *start;
	  void create(WORD *pt,FILE *fin);
	  void display(WORD * pt,FILE *fout ); 
      fin=fopen("cp50610.dat","r");
      fout=fopen("cp50610.out","w");
      fprintf(fout,"**********************\n");
      fprintf(fout,"       OUTPUT\n");
      fprintf(fout,"**********************\n");
      
	start=malloc(sizeof(WORD));/* get space for first node*/
	create(start,fin);
	display(start,fout);
  
      fclose(fin);
      fclose(fout);
      	return 0;
}/* end main*/


void create(WORD *record, FILE *fin)    /*to create the list */
 /* argument points to current node; function is recursive */
 /* strings are input until string END is encountered */
  {char temp[30]; /*temporary storage for string */
   int k; /*length of current string */
   
   fscanf(fin," %[^ ,.;?\n]",temp); /*input into temp to get length */
   k = strlen(temp)+1; /*need room for null character */
   record->word=malloc(k*sizeof(char)); /*get address for permanent storage of string */
   strcpy(record->word,temp); /*put string there */ 
     record->next = malloc(sizeof(WORD));
     create(record->next,fin); 
    
     } /*end of create */
    
    void display(WORD * record,FILE *fout)  /*to print linked list */
/*argument points to start of list */
 {      
           fprintf(fout,"%s\n",record->word); /* print this one */ 
      while(record->next != NULL)  /* & walk down list */
        { record = record->next;
           fprintf(fout,"%s\n",record->word); /* print this one */
        }   
 } /*end of display */

You should strcmp(test, "END"), and then set record->next = NULL; and return; if they're the same in create.

Originally Posted by Tonto

You should strcmp(test, "END"), and then set record->next = NULL; and return; if they're the same in create.

Oh please sorry never mind the comment about the END thing I was testing my function earlier with that..
Sorry I forgot to remove this comment.
This should not be the issue here!

You got to stop that recursion at some point.

Originally Posted by Tonto

You got to stop that recursion at some point.

you are right I 'll try to fix that.