Dynamic array resizing

[farklem]

I have written some simple code to add/remove items to/from an array. I am trying to modify the code so that it will accept any data type instead of having a make a new add/del function for each data type I use. Here is what I have:

This code works just fine but only works with the vhost data type.

typedef struct _vhost vhost;
struct _vhost
{
	char group_id[12];
	char host[100];
};
int vhost_count = 0;
static vhost *vhost_list;

void add_vhost_list(vhost **list, int *count, vhost vhost_add)
{
	vhost *tmp_list = (vhost*)malloc((vhost_count * sizeof(vhost)) + sizeof(vhost));

	int x;
	for(x = 0; x < vhost_count; x++)
		tmp_list[x] = (*list)[x];

	if(vhost_count < 1)
		tmp_list[0] = vhost_add;
	else
		tmp_list[x] = vhost_add;

	vhost_count++;

	*list = tmp_list;
}

void del_vhost_list(vhost **list, int *count, int index)
{
	if(vhost_count > 0 && index <= vhost_count)
	{
		vhost *tmp_list = (vhost*)malloc((vhost_count * sizeof(vhost)) - sizeof(vhost));

		int x;
		for(x = 0; x < vhost_count - 1; x++)
			if(x < index)
				tmp_list[x] = (*list)[x];
			else
				tmp_list[x] = (*list)[x + 1];

		vhost_count--;

		if(vhost_count > 0)
			*list = tmp_list;
	}
}

int main()
{
	vhost tmp_vhost;
	strcpy(tmp_vhost.group_id, "-4724684");
	strcpy(tmp_vhost.host, "omg.com");
	add_vhost_list(&vhost_list, &vhost_count, tmp_vhost);
}

[SlyMaelstrom]

realloc?

[Salem]

> vhost *tmp_list = (vhost*)malloc((vhost_count * sizeof(vhost)) + sizeof(vhost));
There's no need to cast malloc in C
See the FAQ for details.

> I am trying to modify the code so that it will accept any data type
The only real 'any' datatype in C is a void*

So what you end up with is an array of void* pointers to your actual data. This particular function doesn't care about what the pointer really points to, but you then have the problem of manually checking that the types are OK when you add/remove things from a given array.

Any particular reason why you can't use C++, and std::vector ?

[farklem]

Thanks for everyone's help so far, im working on using realloc instead of malloc. So far this is what I have but I get a segmentation fault when I try to add an item with my function add_vhost.

typedef struct _vhost vhost;
struct _vhost
{
	char group_id[12];
	char host[100];
};
static int vhost_count = 0;
static vhost *vhost_list;

void add_vhost(vhost **item_list, vhost item)
{
	*item_list = realloc(vhost_list, (vhost_count * sizeof(vhost)) + sizeof(vhost));
	*item_list[vhost_count] = item; // Segmentation fault happens here
}

int main()
{
	vhost tmp_vhost1;
	strcpy(tmp_vhost1.group_id, "-487554");
	strcpy(tmp_vhost1.host, "omg.com");
	vhost_list = realloc(vhost_list, (vhost_count * sizeof(vhost)) + sizeof(vhost));
	vhost_list[vhost_count] = tmp_vhost1;
	vhost_count++;

	vhost tmp_vhost2;
	strcpy(tmp_vhost2.group_id, "874481");
	strcpy(tmp_vhost2.host, "something.net");
	vhost_list = realloc(vhost_list, (vhost_count * sizeof(vhost)) + sizeof(vhost));
	vhost_list[vhost_count] = tmp_vhost2;
	vhost_count++;

	vhost tmp_vhost3;
	strcpy(tmp_vhost3.group_id, "16547");
	strcpy(tmp_vhost3.host, "zoom.org");
	add_vhost(&vhost_list, tmp_vhost3); // Something bad happens
	vhost_count++;

	int x;
	for(x = 0; x < vhost_count; x++)
	{
		printf("%s\n", vhost_list[x].host);
	}
}

BTW, I'm not using c++ because this is a module I am writing for another application that is written in c.