Thread: this doesnt do what i want it to do

Code:

#include<stdio.h>


int
main(void)
{
 char tic_tac_toe[3][3] =
        {{' ', ' ', ' '}, {' ', ' ', ' '}, {' ', ' ', ' '}};

 char i, j;

  for (i=1; i<=3; i=i+1){
      for (j=1; j<=3; j=j+1)
       {
           printf("Please enter symbol in position %d, %d\n",i,j);
           scanf("%", &tic_tac_toe[i][j]);
           scanf("%*[^\n]");
           scanf("%1[\n]");
       }
      }

void print_board (char tic_tac_toe[3][3]){
  int i,j;
  for (i = 0; i < 3; i++){
    for (j = 0; j < 3; j++){
      printf("%c\t", tic_tac_toe[i][j]);
    }
    printf("\n");
  }

}


int has_won (char tic_tac_toe[3][3]){

  if (tic_tac_toe[0][0] == tic_tac_toe[0][1] &&
      tic_tac_toe[0][1] == tic_tac_toe[0][2]){
    printf("%c has won!\n", tic_tac_toe[0][0]);
    return 1;
  }
  else if (tic_tac_toe[2][0] == tic_tac_toe[2][1] &&
           tic_tac_toe[2][1] == tic_tac_toe[2][2]){
    printf("%c has won!\n", tic_tac_toe[2][0]);
    return 1;
  }
  else if (tic_tac_toe[0][0] == tic_tac_toe[1][0] &&
           tic_tac_toe[1][0] == tic_tac_toe[2][0]){
    printf("%c has won!\n", tic_tac_toe[0][0]);
    return 1;
  }
  else if (tic_tac_toe[0][1] == tic_tac_toe[1][1] &&
           tic_tac_toe[1][1] == tic_tac_toe[2][1]){
    printf("%c has won!\n", tic_tac_toe[0][1]);
    return 1;
  }
  else if (tic_tac_toe[0][2] == tic_tac_toe[1][2] &&
           tic_tac_toe[1][2] == tic_tac_toe[2][2]){
    printf("%c has won!\n", tic_tac_toe[0][2]);
    return 1;
  }
  else if (tic_tac_toe[0][0] == tic_tac_toe[1][1] &&
           tic_tac_toe[1][1] == tic_tac_toe[2][2]){
    printf("%c has won!\n", tic_tac_toe[0][0]);
    return 1;
  }
  else if (tic_tac_toe[0][2] == tic_tac_toe[1][1] &&
           tic_tac_toe[1][1] == tic_tac_toe[2][0]){
    printf("%c has won!\n", tic_tac_toe[0][2]);
    return 1;
  }
  else return 0;
 }

}

*what did you want it to do
*where do you think it's going wrong
*you need a better thread title
*why are you posting c code on the C++ board?

Psst, this isn't the C++ board.

> for (i=1; i<=3; i=i+1)
Arrays start at 0, not 1

> scanf("%", &tic_tac_toe[i][j]);
You need to work on your use of scanf - two of the calls are broken.
This one for example does NOT read a char (or anything else)

> void print_board (char tic_tac_toe[3][3])
1. It seems to be declared inside main - C doesn't have nested functions
2. You don't have a prototype for it.
3. You don't call it from main.

Your input function writes past the bounds of the array.
Arrayindexes in c/c++ range from 0 to num-1 ( 0..2 in your case ).
Your print_board() function would print only a 2x2 board ( you use indexes from 1 to 2 )
Kurt
EDIT: just noticed Salem has already told you all of this

> tell me if im getting warmer
Nope - you're getting further away.
Sure you fixed the nested function problem, but you added some more problems along the way, like breaking the print_board() function.

Code:

scanf("%", &tic_tac_toe[i][j]);

% what?

theman29, Please

1) give an explanation what these 4 lines do in general, then
2) what each line specifically does -- in detail. I'd like to know what you are thinking:

Code:

printf("Please enter symbol in position %d, %d\n",i,j);
scanf("%", &tic_tac_toe[i][j]);
scanf("%*[^\n]");
scanf("%1[\n]");

3) Have youe ever heard of the function getchar()?

3) Have youe ever heard of the function [i]getchar()?

Code:

user@0[~]$ man [i]getchar
No manual entry for [i]getchar
user@0[~]$

Nope.

Code:

           printf("Please enter symbol in position %d, %d\n",i,j);
           scanf("%", &tic_tac_toe[i][j]);
           scanf("%*[^\n]");
           scanf("%1[\n]");

I suspect you're trying to do something like this:

Code:

           printf("Please enter symbol in position %d, %d\n",i,j);
           scanf("%c", &tic_tac_toe[i][j]);