Reading problem

Code:

#include "bst_inter.h"

void bst_letter_fill ( tree_t *T )
{
  FILE *in;
  char read;
  bst_item data;
  int check;

  in = fopen("fill.txt", "r");

  while (fscanf(in, "%c ", &read) != EOF);
  {
    data.code = read;
    data.key = read;
    bst_insert(T, &data);
  }
  fclose (in);
}

This read statement is supposed to fill up a previously declared and initiallized binary search tree with the contents of fill.txt,

E A R I O T N S L C U D P M H G B F Y W K V X Z J Q

but is only going through the while loop once, recording Q. Any ideas why that is happening, and not recording the entire text file? It should be some simple, stupid reading error. Any help is appreciated

You have an empty while loop.

Code:

while (fscanf(in, "%c ", &read) != EOF);

It may be better to check for a successful read to enter the body of the loop.

Code:

while ( fscanf(in, "%c ", &read) == 1 )

Thanks for pointing out the semi-colon, it loads now

New problem, this one is kinda crazy. The program reads correctly up to the value G, then letters start getting mixed up.

Code:

#include "bst_inter.h"

void bst_letter_fill ( tree_t *T )
{
  FILE *in1, *in2;
  bst_item data;

  in1 = fopen("english.txt", "r");
  in2 = fopen("cipher.txt", "r");

    while (fscanf(in1, "%c", &data.key) != EOF && fscanf(in2, "%c", &data.code) != EOF)
      bst_insert(T, &data);

    fclose (in1);
    fclose (in2);
}

where data includes a code character and a key character.

english.txt: ABCDEFGHIJKLMNOPQRSTUVWXYZ
cipher.txt: TSWEPFARUZMBCIYLJXHQOKNGVD

The resulting tree is:

Code: A Key: T
Code: B Key: S
Code: C Key: W
Code: D Key: E
Code: E Key: P
Code: F Key: F
Code: X Key: G
Code: H Key: R
Code: I Key: U
Code: J Key: Z
Code: K Key: M
Code: W Key: N
Code: P Key: L
Code: O Key: Y
Code: T Key: Q
Code: R Key: X
Code: Y Key: V

Any ideas why it would not read (or print?) the whole text file, and why the letters only start getting rearranged after F? Any help is greatly appreciated!

Put in some useful prinf statements in your insertion function, in your loop, etc, printing out what data is read, and the like. This is a common and useful method for finding out where your problems occur.


Quzah.

Thanks. printf. I fixed it.

FYI...

fscanf() is a powerful waste of time, and memory for reading a character. It's designed for reading complex input.

fgetc() is designed for reading characters and will do a better job faster, easier, and with less chance for mistakes.