2 dimension array of characters

Hi , I am stuck with two dimension array of characters.

for example, I have 4 lines in a file( lines should be treated as arrays of string) called source:

i am not good at C.
i hope improve soon.
i need help.
it is very cold.

I want read the first two lines and store them in a new 2-dimension array of characters called destination.

I know how to read (all the lines but not the first two) but when I tried to input the line in destination I get errors: I tried strcpy, memcpy...

What can I do please?
B

Use a loop. Read a line into a buffer. Do something with it. Repeat until you feel like stopping. Consider fgets. Also consult the FAQ section of the site.


Quzah.

I know how to read (all the lines but not the first two) but when I tried to input the line in destination I get errors: I tried strcpy, memcpy...

What can I do please?

post the relevant code if the faqs don't help

Originally Posted by MadCow257

post the relevant code if the faqs don't help

Ok this is my code:

Code:

 while(fgets(line,19,fin)!=NULL) {/* while begins*/
          for(i=0;i<2;i++)
         {            
            strcpy(destination[i],source[i]);/*this is where I mess up*/
           fputs(source,fout);
         }
for(i=0;i<19;i++)
fputs(destnation[i],fout);}

My idea is to copy what I read from the file and put it in an array.
whem I try to introduce the double subscript like destination [i][j], it still give me error.
please, I need help since I dont suceed to find a solution.

Thank you
B

How is destination and source declarated? And what does source contain? What is the error you're getting?

Originally Posted by OnionKnight

How is destination and source declarated? And what does source contain? What is the error you're getting?

This is how I declared the arrays.

char source[20];
char destination[2][20];

My problem is that I read a numer of line from an input file.
I decided to called source each line read from the file.

I get the error: [Warning] passing arg 1 of `strcpy' makes pointer from integer without a cast

I tried a lot of comination but I get basically the same error.

thank you

Originally Posted by braddy

My problem is that I read a numer of line from an input file.
I decided to called source each line read from the file.

Code:

 while(fgets(line,19,fin)!=NULL) {/* while begins*/

In your code you are reading each line into a variable called line but I don't see you putting the contents of line into source anywhere.

Code:

strcpy(destination[i],source[i]);/*this is where I mess up*/

source[i] is of type char. What you wanted was probably

Code:

strcpy(destination[i],source);/*this is where I mess up*/

Originally Posted by OnionKnight

Code:

 while(fgets(line,19,fin)!=NULL) {/* while begins*/

In your code you are reading each line into a variable called line but I don't see you putting the contents of line into source anywhere.

Code:

strcpy(destination[i],source[i]);/*this is where I mess up*/

source[i] is of type char. What you wanted was probably

Code:

strcpy(destination[i],source);/*this is where I mess up*/

Code:

 while(fgets(line,19,fin)!=NULL) {/* while begins*/

line is a typo I meant to write source instead.

I just try:

Code:

strcpy(destination[i],source);/*this is where I mess up*/

[/QUOTE]
but it still gives me error

my problem is to create this 2-D array of characters.Besides strcpy there are other way to do it?

Thank you

Well, there's a lot of strange things going on in your code.

Code:

 while(fgets(line,19,fin)!=NULL) {/* while begins*/
          for(i=0;i<2;i++)
         {            
            strcpy(destination[i],source[i]);/*this is where I mess up*/
           fputs(source,fout);
         }
for(i=0;i<19;i++)
fputs(destnation[i],fout);}

For each line you're reading that line gets copied into the two buffers of destination and the line gets written to fout two times. After that destination seems to be storing 19 buffers instead of 2 and those two buffers plus the mysterious potentially segfaulting 17 others gets written to fout.
There are other way than strcpy but they don't differ much and strcpy doesn't seem to be your problem.

[edit]
I need to get my ass to school so let's get down to brass tacks, I think you want something like this.

Code:

for (i = 0; i < 2; i++) {
    if (fgets(source, 20, fin) != NULL) {
        strcpy(destination[i], source);
        fputs(source, fout);
    }
    else {
        //errors
    }
}

You can also skip the use of source entirely by reading directly into destination e.g. fgets(destination[i], 20, fin)

Originally Posted by OnionKnight

Well, there's a lot of strange things going on in your code.

Code:

 while(fgets(line,19,fin)!=NULL) {/* while begins*/
          for(i=0;i<2;i++)
         {            
            strcpy(destination[i],source[i]);/*this is where I mess up*/
           fputs(source,fout);
         }
for(i=0;i<19;i++)
fputs(destnation[i],fout);}

For each line you're reading that line gets copied into the two buffers of destination and the line gets written to fout two times. After that destination seems to be storing 19 buffers instead of 2 and those two buffers plus the mysterious potentially segfaulting 17 others gets written to fout.
There are other way than strcpy but they don't differ much and strcpy doesn't seem to be your problem.

[edit]
I need to get my ass to school so let's get down to brass tacks, I think you want something like this.

Code:

for (i = 0; i < 2; i++) {
    if (fgets(source, 20, fin) != NULL) {
        strcpy(destination[i], source);
        fputs(source, fout);
    }
    else {
        //errors
    }
}

You can also skip the use of source entirely by reading directly into destination e.g. fgets(destination[i], 20, fin)

Thank you very much!!!!!!!