file: fscanf problem

i used this codes to enter records at a file:

Code:

	fp=fopen("account.dat","w+");
	clrscr();
	for(x=0; x<3; x++) {
		printf("\nEnter account number: ");
		scanf("%s",&record[x].accountno);
		printf("\nEnter PIN: ");
		scanf("%s",&record[x].accountpin);
		printf("\nEnter initial balance: ");
		scanf("%d",&record[x].balance);
		for(y=0; y<5; y++) fprintf(fp,"%c",record[x].accountno[y]); fprintf(fp," ");
		for(y=0; y<4; y++) fprintf(fp,"%c",record[x].accountpin[y]); fprintf(fp," ");
		fprintf(fp,"%d\n",record[x].balance);
		}

i input accountno, accountpin, and balance thrice and respectively: and account.dat contains:

abcde 1234 2000
fghij 5678 4000
klmno 9012 6000

and in another program, i used fscanf to load up the records... but some special characters appear in part of record[x].accountpin,

http://i35.photobucket.com/albums/d1...vin/cerror.jpg

Code:

fp=fopen("account.dat","r+");
	clrscr();
	for(x=0; x<3; x++) {
	fscanf(fp,"%s",&record[x].accountno);
	fscanf(fp,"%s",&record[x].accountpin);
	fscanf(fp,"%d",&record[x].balance);
	printf("%s %s %d \n",record[x].accountno,record[x].accountpin,record[x].balance);}

help me pls, how can i load up my records w/o any errors? as you can see in the image, accountpin merge with accountno, and it contains some special character, and i dont know why...

> for(y=0; y<5; y++) fprintf(fp,"%c",record[x].accountno[y]);
You're printing the junk in the string which is left there from previous runs.
Since you read a string, just do
fprintf(fp,"%s",record[x].accountno);

Looking at that output you provided, it's obvious that you're accountno and accountpin fields are not properly NULL terminated... or you aren't using %s correctly in this case.

Code:

printf("%s %s %d \n",record[x].accountno,record[x].accountpin,record[x].balance);

When you print the accountno field you get abcde1234 (this is because you are using %s and there is no NULL after the accountno field which is what %s looks for to stop its printing) followed by the funky character and then fortunately you seem to encounter a NULL which stops the printing. Then you print accountpin and again get 1234 followed by the funky character because there is no proper NULL after those 4 characters.

You can either increase the size of those fields by 1 character and make sure you NULL terminate them before printing or you can alter your printf statement slightly to this:

Code:

printf("%5.5s %4.4s %d \n",record[x].accountno,record[x].accountpin,record[x].balance);

i think i dont have any problem in printing, my purpose of printing the output is to know if my variables has the same value, may i know how i can load up the records with no errors or how can i fscanf / fread in a proper way?

sorry for the late details

how i can load up the records with no errors or how can i fscanf / fread in a proper way?

well, the use of fscanf in your code is right to an extent. if u look at Salems post u will come to know where the mistake is. as u are reading the string from the file dont need to specilfy the &(address of operator ). i have posted u a sample code of how to use the fscanf. and about the fread() fucntion, as far as u conser me u dont need that fucntion in your code. this fucntion basically used for reading data from binary file in terms of chunks of bbytes from the file. it make more sense when u wanted to read one record at a time from a file binary file.

Code:

#include<stdio.h>

int main()
{
    FILE *fp;
    char str[25];
    int num1,num2,num3;
    
    if((fp = fopen("test.txt","r+"))==NULL)
    {
        printf("Error: File cannot be opened\n");
        getchar();
        return 1;
    }
    else
        fscanf(fp,"%s %d %d",str,&num2,&num3);
    
    printf("%s [ %d %d ]",str,num2,num3);
    fclose(fp);
    getchar();
    return 0;
}
/* my output
hello [ 10 20 ]

my test.txt file
hello 10 20
*/

ssharish2005