Escaping an infinite loop

I am trying to work on a note program that I have been working on for a long time and wanted to add a new feature. Up until now the user has only been able to enter a 1 line note. I wanted to make it so that they can use as many lines as they want. This is how I have it so far.

Code:

---

while(1){
        fgets(text,1000,stdin);
        fprintf(fp,text);
    }

---

That works but then the user needs to entirely exit the program to stop it. I wanted to add an if statement so that they could enter a character to terminate the note. Like this...

Code:

---

while(1){
            fgets(text,1000,stdin);
            if(text=='~'){
                          break;
          }
          fprintf(fp,text);
    }

---

This compiles with no warnings but then when I run it just keeps going and does not exit the infinite loop when they enter a ~. Why is this?
~Sven

Did you mean this?

Code:

---

if(*text=='~'){

---

[edit]Maybe this?

Code:

---

  while ( fgets(text, sizeof text, stdin) )
  {
      if ( *text == '~' )
      {
        break;
      }
      /* ... */
  }

---

[edit=2]Oy, but a pokey edit. Sly: :p

I'd imagine that text is some sort of character array. In which case you'd have to dereference the name in order to get the value (assuming it's the only thing in the array) or you'd have to just check (text[strlen(text)-1] == '~').

EDIT: *petting his cat* "I'll get you NEXT time, Sinkula. NEXT TIME!"

Thanks guys I didn't know that I needed to dereference in this case. Thanks again.
~Sven

I also think '~' is kind of a weak way to exit too. There is no confimation that someone wouldn't actually want that at the beginning of a note for some reason. You should make it more solid.

Code:

---

while(fgets(text,1000,stdin) && strcmp(text, "END NOTE\n") != 0){
    fprintf(fp,text);
}

---

I was coming up with a symbol that no one ever uses. I couldn't think of anything better. As I start my next line with a ~.
~Sven

It's used in Diku derived MUDs to denote the end of a string in area / player / etc files.


Quzah.

How about:

Code:

---

while ( fgets(text, 1000, stdin) )
{
    if (text[0] == '\n' )
    {
        break;
    }
      /* ... */
}

---

A blank line indicates no more note.

Quote:

---

Originally Posted by WaltP

How about:

Code:

---

while ( fgets(text, 1000, stdin) )
{
    if (text[0] == '\n' )
    {
        break;
    }
      /* ... */
}

---

A blank line indicates no more note.

---

"...oops I hit enter twice... woe is me."

Not to mention the fact that I (like some others) like a blank line between paragraphs.

*On a side note: I've never tried any DikuMUD based MUDs, if I recall, I've only played CircleMUD based.

Quote:

---

Originally Posted by SlyMaelstrom

"...oops I hit enter twice... woe is me."

Not to mention the fact that I (like some others) like a blank line between paragraphs.

*On a side note: I've never tried any DikuMUD based MUDs, if I recall, I've only played CircleMUD based.

---

"Oops I entered ~100... woe is me."

Sometimes a ~ is meant to mean approximately.

You gotta define the limitations of your input. I just gave an alternative, Didn't mean to start a "war between the delimiters"! ;)

Does this count as MUD slinging? :p

Quote:

---

Originally Posted by WaltP

"Oops I entered ~100... woe is me."

---

Yeah, I guess you're right, that would be a problem wouldn't it. I'm sorry for suggesting your idea had flaws. I'm starting to agree with the other guy who made your point earlier.

Quote:

---

Originally Posted by SlyMaelstrom

I also think '~' is kind of a weak way to exit too.

---

Oh wait... that was me.

Quote:

---

Originally Posted by SlyMaelstrom

*On a side note: I've never tried any DikuMUD based MUDs, if I recall, I've only played CircleMUD based.

---

Click 'derived' above. ;)


Quzah.

Oh wow... did... ANYTHING not derive from DikuMUD? In any event, it's been a while and don't recall the usage of ~. ;)