Problem with .txt file

**shad0w** · 12-24-2001

I have this problem with binary files. I cant access the file properly. Here is a portion of my program:-

main(){
char name[1000];
int x,num;
FILE *fptr;
fptr=fopen("name.txt","w");
printf("Enter number of names: ");
scanf("%d", &num);
for(x=0;x<num;x++){
printf("Enter name: ");
scanf("%s", name);
fwrite(&name, sizeof(name),1,fptr);
}
fclose(fptr);
fptr=fopen("name.txt", "r");
while(fgets(name,1,fptr)!=NULL){
fscanf(fptr,"%s",&name);
...
...
}
}

the problem is that i cant read more than 1 name in the list
If I save more than 1 name in the .txt file, then when i try to read it, there will be some error.Please HELP. I'm a beginner.

**nvoigt** · 12-24-2001

a) I will move this to the C Borad as soon as I posted this reply. It's not C#.

b) When writing/reading files, always use coresponding pairs of read/write functions. When you write your data with fwrite, you need fread to read it. If you want to read it with fgets, the best way would be to use fputs to write it. fprintf/fscanf would be another pair. It's not the only solution, but the simplest and least error prone.

You don't need any binary stuff here. It's a textfile. I'd suggest using fscanf/fprintf. In your loop, you read two times each loop. Once in the while condition with fgets, then a second time with fscanf. You only need to read once inside your loop. Use EOF to check if you are at the end of the file.

**GaPe** · 12-24-2001

Do like this:

while (fscanf(fptr, "%s", &name) != EOF)
{
fread(&name, sizeof(name), 1, fptr);
printf("Name: %s", name);
}

**shad0w** · 12-24-2001

There's still a problem with the program.
The error only occurs when I enter more than 1 name.
An error screen will popup saying that this program has performed an illegal operation.
Why is this happening?

**GaPe** · 12-24-2001

Ups, a mistake, fixed code:

int i;

for (i=0; i<=NoOfNames; i++)
{
fread(&name[i], sizeof(name), 1, fptr);
printf("Name: %s", name);
}

it's the same with fwrite. If you use it in for loop you have to write it like this:

for(x=0;x<num;x++)
{
printf("Enter name: ");
scanf("%s", name);
fwrite(&name[x], sizeof(name),1,fptr);
}

**shad0w** · 12-24-2001

okok...i got it thanx alot u guys but there's still another problem regarding the fscanf or fgets call
I've modified my program to

main(){
char name[100];
int x,name;
FILE *fptr;
fptr=fopen("name.txt","w");
printf("Enter number of names: ");
scanf("%d", &num);
for(x=0;x<num;x++){
printf("Enter name: ");
scanf("%s", name);
fwrite(&name, sizeof(name),1,fptr);
}
fclose(fptr);
fptr=fopen("name.txt", "r");
while (fscanf(fptr, "%s", &name) != EOF) {
fread(&name, sizeof(name), 1, fptr);
printf("Name: %s", name);
}
}

the problem is that the fread doesnt jump to the nextline in the txt file and it doesnt read the next name in the list

**GaPe** · 12-24-2001

Look at my code.

**quzah** · 12-24-2001

Look at my code.

Code:

Ups, a mistake, fixed code: 

int i; 

for (i=0; i<=NoOfNames; i++)

Ok. There's a problem with it. That should be < and not <=

Quzah.

Thread: Problem with .txt file

Thread Tools

Search Thread

Display

Problem with .txt file

Similar Threads

A development process

Problem with file and array

Need Help Fixing My C Program. Deals with File I/O

help with text input

C++ std routines