Thread: This is my problem!

Post some more of your code and what the desired output is as well as the actual output. What you have now isn't enough to know what's wrong.

this is the code that have problem.

int nbeam()
{
int nfield=0,counter;
char sure;
textcolor(5);
for (counter=1; counter<161;counter++)
printf("Ä");


gotoxy(35,3);
textcolor(1);
cprintf("New Beam Menu");

textcolor(3);
printf("\n");
for (counter=1; counter<161;counter++)
cprintf("Ä");
textcolor(9);
printf("Enter number of field: \n");

scanf("%d",&nfield);/*I think HERE is THE PROBLEM*/
while(1)
{
printf("Are you sure %d fields \n",nfield);
sure=getch();
sure=tolower(sure);
switch (sure)
{
case 'y': break;
case 'n': {clrscr();gotoxy(0,0); nbeam();break;}
default : {printf("Y OR N Please!\n"); continue;}
}/*end of switch*/
break;
} /*end of while*/
printf("%d",nfield);/* <----------- it print's all the inputs that the user try*/

return (0);
}/*end of function(nbeam)*/

The Output I want is : the lastest number that user hit. but I get all the numbers that the user hit by wrong.

The problem is with the scanf, when you use it with numbers the '\n' is left in the keyboards buffer, so the next time you call it, it won't read anything.
Use fgets followed by sscanf to avoid this problem

Code:

char temp[5];
int var;

printf("\nEnter a number ");
fgets(temp, sizeof(temp)-1, stdin);
sscanf(temp, "%d", &var);

It may seem like extra hassle, but it's better than using scanf

if your nbeam function is called 10 times, then you have 10 nfields, each will be printed. Do you have to use recursion?

It could all be done in 1 loop.

Code:

while(1)
{
    printf("Enter number of field: \n"); 
    fgets(temp, sizeof(temp)-1, stdin);
    sscanf(temp, "%d", &nfield);

    printf("Are you sure %d fields \n",nfield); 
    sure=getch(); 
    sure=tolower(sure); 

    if(sure == 'n')
        continue;     /* start loop again */
    else
        break;         /* leave loop */
}

But if the user put by wrong 'b' instead Y or N.. it will be as he hits Y ???

I'm sure you could figure that out???

Code:

while(1)
{
    printf("Enter number of field: \n"); 
    fgets(temp, sizeof(temp)-1, stdin);
    sscanf(temp, "%d", &nfield);

    printf("Are you sure %d fields \n",nfield); 
    
    while((sure = tolower(getch())) != 'y' && sure != 'n');

    if(sure == 'n')
         continue;     /* start loop again */
     else
         break;         /* leave loop */
}

The inner while loop won't stop unless a y or n is input, it does everthing on one line as well, which is cool.