Thread: fflush(stdin)

> that's not a reliable way to do it either -- what happens when the string contains multiple occurrences of '\n' ?
fgets() can only return at most ONE \n
If fgets() does store a \n, then it will always be at the end of the buffer, just before the \0

Originally Posted by Salem

> anybody spot any flaws?..
That your if and else parts both do exactly the same thing, thus rendering the comparison useless, and the code wrong.
That the whole method breaks down horribly (without warning) if buffer is a pointer, and not an array.
That a more reliable way has already been posted in the FAQ.

i enter text, how can buffer be a pointer?..

As for the whole "it doing the same thing" issue, yuo are of course correct. I actually copied similar code from the faq and there it had a different if, but as that didin't work, I changed the if part without realising that that was what the else did. now I'm just using

buffer[strlen(buffer)-1]='\0';

and it works for just "/n" and for "blabla/n"...

Originally Posted by mako

i enter text, how can buffer be a pointer?..

Code:

void input_text( char * buffer ) {
   fgets(buffer, 20, stdin);
   int sz = sizeof(buffer);  // now buffer is a pointer 
                             // check yourself what sizeof returns. hint: it's not 20
}

int main() {
   char buffer[20]; // this is an array ( sizeof(buffer) will be 20 );
   input_text(  buffer );
}

Kurt

Originally Posted by ZuK

Code:

void input_text( char * buffer ) {
   fgets(buffer, 20, stdin);
   int sz = sizeof(buffer);  // now buffer is a pointer 
                             // check yourself what sizeof returns. hint: it's not 20
}

int main() {
   char buffer[20]; // this is an array ( sizeof(buffer) will be 20 );
   input_text(  buffer );
}

Kurt

my point is that the application inputs text from a user. I've tried both cases, /n and text/n and it works for both. There's no way a user can input a pointer, so I don't see any need to adapt my program. It suits my needs just fine.

Well at least ZuK understands the issues

Originally Posted by Salem

> that's not a reliable way to do it either -- what happens when the string contains multiple occurrences of '\n' ?
fgets() can only return at most ONE \n
If fgets() does store a \n, then it will always be at the end of the buffer, just before the \0

Yep you are right -- I even tried it in XP with a *nix file and it still worked, and even when the file was opened in binary mode.