Thread: File I/O problem

I'm trying to read a text file in C and insert all of the words in the file to a linked list which will then later be traversed.

I've coded my program to take a file specified at the command line, open it and read each word one by one inserting it into the list. However on compiling and running the program it seems to go into an infinate loop, taking up a lot of processing power and writing lots to the disk (on both windows and linux systems).

If anyone can help, that'd be great.

Code:

#include <stdlib.h>
#include <stdio.h>

typedef struct L {char *word; struct L *next;} List;

List *insertlist(char *head, List *tail) {
	List *t = calloc(1, sizeof(List));
	t->word = head;
	t->next = tail;
	return t;
}

int *makelist(FILE *fp) {
	List *wordlist;
	char *word;
	while (feof(fp) == 0) {
		fscanf(fp, "&d", &word);
		insertlist(word, wordlist);
	}	
	return 0;
}

int main (int argc, char *argv[]) {
	FILE *fp;
	if (fopen(argv[1], "r") != 0) {
		fp = fopen(argv[1], "r");
		makelist(fp);
		fclose(fp);
	} else {
		printf("No such file\n");
	}
	return 0;
}

thanks in advance.

before doing thing with linked list u need to know how to read a file and fetech the data from file. the code below

Code:

fscanf(fp, "&d", &word);

should be 

fscanf(fp, "%s", word);

its not '&' there its % its the format specifier and the u dont nned to give the address of the string as the string name itself is an address to starting location of the string

2. need to update the wordlist pointer

Code:

wordlist = insertlist(word, wordlist);

3. need to initalize the workdlist pointer before u call the insert fucntion

Code:

List *wordlist = NULL;

ssharish2005

Also, why call fopen() twice? Usually it's done something like this:

Code:

  FILE *fp;
  fp = fopen ("whatever", "r");
  if (fp == NULL)
    perror ("whatever");

As for the rest, you need to decide what you're storing. Probably you want to read the file into a buffer and store pointers to the words in your llist.

I'd personally not use fscanf(), either; I'd filter the file myself with fgetc() ... but there's more than one way to do it, I suppose ...

thanks for your help guys

stupid mistakes on those typos

have since rewritten using fgetc()