While loop ..crating an infanat loop

OK ... aparently I cant figure out how to write a while loop .. here is the code and I am using dev C++ the code asks for for the student name and just keeps asking... were can I find good information on how to write this part corectly.

Code:

---

#include <stdio.h>
#include <stdlib.h>
int main(int argc, char *argv[])
{
  char studnam [30]; 
  int bye = 0;
  int prtrep = 0;
  int score = 0;
  char grade [1];
  int average = 0;
while (studnam != "bye")
      printf("Please enter the first and last name of the student.\n");
      scanf("%s",&studnam);
      printf("Please enter test score 1 for student %s.\n",studnam);
      scanf("%d",&score);
      printf("Please enter test score 2 for student %s\n",studnam);
       
{     
if (average  <= 59);
printf("grade is 'F'\n.");

if (average >= 60 <= 69);
printf ("grade is 'D'.\n");

if (average <= 70 >= 79)
printf("grade is 'C'.\n");

if (average <= 80 <= 89)
printf("grade is 'B'.\n"); 

if (average <= 90 <= 100)
printf("grade is 'A'\n");   
}


      printf("Would you like to print the entered informaion?");
      scanf("%d", prtrep);
      printf("1: Print Report");
      printf("2: Exit Program");
{
      if (prtrep == 2);
      printf("than print file grades record");

      if (prtrep == 1);
      printf("Hit enter to exit program now.");
}     
 
      system("PAUSE");
      return 0;
}

---

Turn on warnings to a high level. Realize that C isn't C++ and you compare strings using strcmp. Initialize data. Using proper indentation and full bracing.

Code:

---

while (studnam != "bye")

---

try

Code:

---

char bye[3];
strcpy( bye, 'bye'); <---- or "bye"
while ( strcmp(studnam, bye ) != 0 ){}

---

This is your entire loop, as you've written it:

Code:

---

/* infinite loop */
while (studnam != "bye")
      printf("Please enter the first and last name of the student.\n");

---

Nothing else you've written past this point will execute because with no opening brace following the while statement, only the next line will execute. And obviously your condition can never be met (not just because of this, but also because, as has been mentioned, your test is broken).

What you want is something like this:

Code:

---

  while (strncmp (studname, "bye", 3) != 0)
  {
    /* stuff you want to do in the loop */
  }

---

Your code is wrong for a few reasons:
1 - You must use " when dealing with strings of characters. ' is used for single characters.
2 - Your array bye doesn't have enough room in it for the null character, so you're not allowed to use that array as if it were a string. You'll need at least 4 bytes in your array if you plan on using it the way you currently are.


Quzah.

Code:

---

scanf("%s",&studnam);

---

In addition to everything said above, check this line. It will crash sooner or later. Right now, it's probably working because "bye" is the same size as the address of your array. Once it gets larger, you'll be in all kinds of trouble.

Quote:

---

Originally Posted by quzah

Your code is wrong for a few reasons:
1 - You must use " when dealing with strings of characters. ' is used for single characters.
2 - Your array bye doesn't have enough room in it for the null character, so you're not allowed to use that array as if it were a string. You'll need at least 4 bytes in your array if you plan on using it the way you currently are.


Quzah.

---

Thanks, quzah for pointing that out.
I thought that a char[3] can store at to 3 characters, because one character takes 1 byte. Why do I need an extra byte for?
Thanks in advance.

Quote:

---

Originally Posted by Afrinux

I thought that a char[3] can store at to 3 characters, because one character takes 1 byte. Why do I need an extra byte for?
Thanks in advance.

---

A string in C is nul-terminated by definition, so you need room for the \0.