Need some help with this small code

Hi,

I just started learning c and i was if anyone could i can print the number of runs from the code below at the end instate of after each run.

Thanks!!

Code:

#include <stdio.h>      //printf
#include <string.h>     //strcmp
int main(){
 int x,y,runs,best=0,count=0;
 while ( scanf("%d", &x) == 1 )
  {
     if(x!=NULL)
      {
           runs++;
           printf("%s"," ");
           printf("%s","(");
           printf("%d", x);
           printf("%s",")");
       }
     printf("%d Number runs: ", runs);
     
  }
}

/*
sample input:

3  2 2 2  1 1 2 2
 Sample output:

 (3) (2 2 2) (1 1 2 2)
 Number runs: 3
 
*/


Instate i get this output:

(3)Number runs:  1(222)Number runs:  2(1122)Number runs: 3

Originally Posted by axe

Hi,

I just started learning c and i was if anyone could i can print the number of runs from the code below at the end instate of after each run.

Thanks!!1 - x will never be NULL. NULL is a macro usually reserved for pointer comparison. You should just check to see if it's zero. In theory, they're the same thing, but there are minor differences between the two.

2 - Just increment count inside your if check.
3 - Print the number of runs (count) when you're at the bottom.
4 - A function that is set to return a non-void type should always have a return statement. It's just good form.


Quzah.

The big problem you have at the moment is than scanf() doesn't tell you how many spaces it skipped over from one int to the next.

If you're looking at that level of detail in a string, then you should start by reading a whole line into a buffer using say fgets. Then you can parse that string looking at integers, counting significant spaces or whatever.

Code:

#include <stdio.h>      //printf
#include <string.h>     //strcmp
int main(){
 int x,y,runs,best=0,count=0;
 while ( scanf("%d", &x) == 1 )
  {
     if(x!=NULL)
      {
           runs++;
           printf("%s"," ");
           printf("%s","(");
           printf("%d", x);
           printf("%s",")");
       }
     printf("%d Number runs: ", runs);
     
  }
}

/*
sample input:

3  2 2 2  1 1 2 2
 Sample output:

 (3) (2 2 2) (1 1 2 2)
 Number runs: 3
 
*/


Instate i get this output:

(3)Number runs:  1(222)Number runs:  2(1122)Number runs: 3

Originally Posted by axe

Code:

#include <string.h>     //strcmp

You aren't using strcmp, or any string related functions for that matter.

Originally Posted by axe

Code:

int main(){
 int x,y,runs,best=0,count=0;

You never use y.

Originally Posted by axe

Code:

     if(x!=NULL)

Stop comparing integers to NULL.

Originally Posted by axe

Code:

      {
           runs++;

You never initialize runs. This means you can't be sure what value it's going to contain before you start using it in your current code.

Originally Posted by axe

Code:

           printf("%s"," ");
           printf("%s","(");
           printf("%d", x);
           printf("%s",")");
       }

This just says:

Always print a space. Then always print a (, then always print the value of x, then always print another ).

Why don't you simply do this instead:

Code:

printf(" (%d)", x );

Originally Posted by axe

Code:

  }
}

You still aren't returning from main. As good practice, you should always return something from functions which return non-void.

Now how about starting to listen to what people tell you, eh?


Quzah.

Code:

Hi quzah,

I think i am now starting to listen and thank. I still have a problem with the output though. I need the output to print the "Number of runs: 4" just once; for intance if i input :

23 2234 435 5
i need it to output:
(23) (2234) (435) (5) Number of runs: 4

instate it outputs:

(23)Number of runs:  1 (2345)Number of runs:  2 (345)Number of runs:  3 (5)Number of runs: 4


#include <stdio.h>      //printf
int main(){
 int x,runs=0;
 while ( scanf("%d", &x) == 1 )
  {
     runs++;
     if(x!=0)
      {
           printf(" (%d)", x);
       }
       printf("Number of runs:  %d",runs);
   }
   return 0;
}

Move the line where you print out the number of runs outside of the loop. That way it only prints it once.


Quzah.

Code:

Hi Quzah,

I tried the way you instructed does not print the number of runs.

 
#include <stdio.h>      //printf
int main(){
 int x,runs=0;
 while ( scanf("%d", &x) == 1 )
  {
     runs++;
     if(x!=0)
      {
           printf(" (%d)", x);
       }
       
   }
   printf("Number of runs:  %d",runs);
   return 0;
}

Code:

goto post3;

Originally Posted by axe

Code:

Hi Quzah,

I tried the way you instructed does not print the number of runs.

 
#include <stdio.h>      //printf
int main(){
 int x,runs=0;
 while ( scanf("%d", &x) == 1 )
  {
     runs++;
     if(x!=0)
      {
           printf(" (%d)", x);
       }
       
   }
   printf("Number of runs:  %d",runs);
   return 0;
}

instead

Code:

#include <stdio.h>      //printf
int main()
{
    int x,runs=0,ch;
    printf("Enter a number ( Q to quit)\n?");
    while ( scanf("%d", &x) == 1 )
    {
        runs++;
        if(x!=0)
        {
            printf(" (%d)", x);
        }
    printf("\nEnter a number ( Q to quit)\n?");
    }
   printf("Number of runs:  %d",runs);
   while((ch=getchar())!='\n' && ch != EOF);
   getchar();
   return 0;
}

/* my output
Enter a number ( Q to quit)
?123
 (123)
Enter a number ( Q to quit)
?456
 (456)
Enter a number ( Q to quit)
?789
 (789)
Enter a number ( Q to quit)
?369
 (369)
Enter a number ( Q to quit)
?q
Number of runs:  4

ssharish2005

Code:

Thank you ssharish2005!