This works on linux...but why not windows?

I am trying to get a game I've been working on for linux to run on windows. It is all compiling ok but when I try and read in the quake to models, fseek is failing to read all the data on the windows build.

using the following code

Code:

	if ( fseek( fp, model_header->offset_triangles, SEEK_SET ) == 0 ) {
		if (( model->nr_triangles = fread( model->triangle,
		    sizeof(*model->triangle), model_header->nr_triangles, fp ))
			!= model_header->nr_triangles ) {
			 fprintf( stderr,"Error reading triangles from model file (%d).\n", model->nr_triangles );
				return NULL;
		}
	}

the value for model_header->nr_triangles is correct but the value that fread returns is not it and the app is failing with the error message.

This works fine on the linux build... is windows different or is my code bad?

Perhaps you failed to open the file in binary mode on windows.

Perhaps the structures are padded differently between the two machines - simply copying a binary file containing structures written with fwrite() from one machine to another is full of fun for all the family.

> stderr,"Error reading triangles from model file (%d).\n"
You could have at least printed the value you expected as well.
In addition, the fseek() call itself needs an "else error message" bit of code.

> is windows different or is my code bad?
Yes and Yes
Or more specifically, your assumptions of portability are probably wrong.

Originally Posted by Salem

Perhaps the structures are padded differently between the two machines - simply copying a binary file containing structures written with fwrite() from one machine to another is full of fun for all the family.

If agree with Salem -- structure padding and alignment will often bite you in the nether regions when transitioning code between Linux and Windows.

I'd start there first......

The files I am reading in are quake 2 models. They come from windows machines.

I am not sure what you guys mean by structure padding and alignment, a google search hasn't helped me to understand either.

I never assumed portability, but I was expecting the errors at compile time and this one has me stumped. Can you please elaborate on padding/alignment for me?

ps: This was the full code block, I removed what i thought was irrelevant to make it more readable:

Code:

print_model_info( model_header );

	/* Load triangles. */
	if ( fseek( fp, model_header->offset_triangles, SEEK_SET ) == 0 ) {
		
		if (( model->nr_triangles = fread( model->triangle,
		    sizeof(*model->triangle), model_header->nr_triangles, fp ))
			!= model_header->nr_triangles ) {
			 fprintf( stderr, "Error reading triangles from model file (%d).\n", model->nr_triangles );
				return NULL;
		}
	} else {
		fprintf( stderr, "Error reading triangles from model file. 2\n" );
		return NULL;
	}

The print_model_info() call does give print the value I was expecting as well as all of the other file header info.

Solved problem, it was binary mode. Something I had never heard of until now nor read in the man page.

Thankyou for you help salem, but I am still interested if you could elaborate on padding please

Originally Posted by Kinasz

Thankyou for you help salem, but I am still interested if you could elaborate on padding please

This link should make things clear.

Thankyou that link has been very helpful