What's wrong with my program?

**Infuriate** · 12-03-2005

Ok, I'm not completely sure what I'm doing wrong as I'm semi-new to programming. Any help would be much appreciated. Is it something with the strrev? not sure if I'm allowed to use it.

Code:

#include <stdio.h>
#include <string.h>
#include <conio.h>

int 
main(void)

{
char words[50][20];
char *reversed;
int i = 0;

printf("=> ");
scanf("%s", &words[i]);

for(i = 0; i < 50; i++);   
    {
          printf("%s ", words[i]);
          if(words[i][0]==';')    
          break;
    }
          reversed = strrev(words[i]);
          printf("%s ", reversed);
           
           getch();
           return (0);
}

**pianorain** · 12-03-2005

I'm not completely sure what you're doing wrong, either. This might have something to do with one or more of the following:

You didn't tell us what the program is supposed to do.
You didn't tell us what problems you were having with the program.
You are using a non-standard header file (conio.h).

However, I can venture a guess. Right now, your for-loop looks like this:

Code:

for(i = 0; i < 50; i++);   
    {
          printf("%s ", words[i]);
          if(words[i][0]==';')    
          break;
    }

Maybe you really wanted it to look like this?

Code:

for(i = 0; i < 50; i++);   
    {
          printf("%s ", words[i]);
          if(words[i][0]==';')    
          break;
    
          reversed = strrev(words[i]);
          printf("%s ", reversed);
    }

EDIT: There's another obvious input error, but I can't help you with it unless you describe how the program should work in more detail.

**Infuriate** · 12-03-2005

Sorry about that, this program is supposed to take input from a user such as "apples and oranges" and then reverse the word order so the outcome would be "oranges and apples".

I'm having a hard time figuring it out. Right now it runs like:

input: dog
output: god

Also, I can't run it because it says my "break" statement is not in the loop, when it is I think. I updated my program to your post.

conio.h is used with getch(); to keep the program from dying in Devc.

Thanks

**ZuK** · 12-03-2005

Thats right your break statement is not in a loop

Code:

for(i = 0; i < 50; i++);

remove the semicolon
Kurt

**Infuriate** · 12-03-2005

Thanks Kurt, now my program runs :P

But, i need it to reverse the word order, right now when i type in cat and dog, it outputs cat tac and then a bunch of messed up weird characters.

**dwks** · 12-03-2005

Try isspace().

**pianorain** · 12-03-2005

Even though I don't know for certain what strrev() does, I can tell you that you do not need it for this program.

**dwks** · 12-03-2005

strrev reverses a string ("hippo" -> "oppih"), which is not what you want.

Thread: What's wrong with my program?

Thread Tools

Search Thread

Display

What's wrong with my program?

Similar Threads

Maze Program - What am I doing wrong?

Program is crashing since I added a new function. Where have I gone wrong?? :S

What is wrong with my code? My first program......

Whats wrong with this program - Output of a series

Whats wrong with my program?