Thread: character string problem

Hi,
I need to write a program that has the user input a command such as ADD (adds two numbers), SUB(subtracts two numbers), DIV( divides), MUL(multiplies) and then input the two numbers. The user is asked to input all three things at one time. Here is the code.

Code:

#include<stdio.h>
#include<math.h>

int performance(char[], int, int);

int main()
{
  int one;
  int two;
  char com[3];
  int FI;

  printf("Enter Instruction:");
  scanf(" %3s %d %d", &com, &one, &two);

  FI =  performance( com, one, two);
  printf("the answer is %d\n", FI);
  return(0);

}

int performance(char A[], int B, int C)
{
  int final;
  char ADD;
  char SUB;
  char DIV;
  char MUL;

  if(A[3] == ADD)
  {
    printf("%d", final);
  }
  if(A[3] == SUB)
  {
    final = B - C;
  }
  if(A[3] == DIV)
  {
    final = B / C;
  }
  if(A[3] ==  MUL)
  {
    final = B*C;
  }
  return(final);
}

I am not getting the right answers. I think it has something to do with my if statements.

please help.
THANKS

1. you haven't given enough room to store a three-character string in array comm -- you forget about the null-terminator. So it should be a minimum of 4, not 3 characters.

2. use strcmp() to check if the string contains specific characters. For example

Code:

 if( strcmp(A, "ADD") == 0)

Well,

char ADD; isnt actually making a string a containing the word ADD, it simply creates a variable called ADD.

Also A[3] is the 4th element in A, i.e if A was "hello", A[3] would be l (the 2nd one).

GAH!!!!
http://cboard.cprogramming.com/showthread.php?t=72794
Stick to one thread