Thread: switch problems...

can anyone find an error in here that would prevent it from switching states?

Code:

static unsigned char state;
   static unsigned char countdown;
   TMR3CN &= ~(0x80);                     // clear TF3
   countdown = countdown-1;
   if (countdown == 0){
   		state = state + 1;
		}

   if (state > 4){
		state = 1;
		}
   switch (state){
   	case 1:
   		P1 = 0x44;
		countdown = 100;
		break;
   	case 2:
		P1 = 0x06;
		countdown = 16;
		break;
   	case 3:
		P1 = 0x11;
		countdown = 100;
		break;
 	case 4:
		P1 = 0x09;
		countdown = 16;
		break;
 	}

initial value of countdown is 0 because globals and static variables are all initialized to 0 by default. decrementing the unsigned will cause data underflow, an undefined behavior. Most compilers will do data wrap-around to 255 but that is not guarenteed.

Short answer: the value of countdown = 255.

Ha ha... you two might communicate better if you stopped deleting posts AFTER the other person read and replied to them.

but i cant just have

Code:

countdown = 255;
countdown = countdown-1;

will it need to be set elsewhere? like in the switch statement?

Originally Posted by sean_mackrory

Ha ha... you two might communicate better if you stopped deleting posts AFTER the other person read and replied to them.

Yea, I know that is a problem, there there is no way to know if the post has already been read. So when I post something that I later discover to be untrue I just delete it, hoping nobody notices

Originally Posted by rexnprogress

but i cant just have

Code:

countdown = 255;
countdown = countdown-1;

will it need to be set elsewhere? like in the switch statement?

First you need to decide what value you want countdown to have initiallly, what is the minimum value (apparently 0) and what is its maximum value (is 255 ok?) Set the initial value when it is declared

Code:

  static unsigned char countdown  = 1;

maybe a prob with my case wording, as i havent associated it with "state", so there may be no connection between the two