fputs only write first part of string

[jamie85]

I am using fputs like so

strcat(linebuf, "\n");
fputs(linebuf, history_stream); 

where linebuf is a string from stdio and history_stream is a text file.

instead of writing "hello i am here" to a text file, it simply write "hello", and misses of the rest of the string.

This a regular problem?

[SlyMaelstrom]

Can I see how you set up the string and the file?

Does it look like this?

   char linebuf[20] = "Hello I am here";
   
   FILE *history_stream;
   history_stream = fopen("test.txt", "w");
   
   strcat(linebuf, "\n");
   fputs(linebuf, history_stream);

[jamie85]

#define MAXLINELEN 4096


char linebuf[MAXLINELEN];

FILE *history_stream;

    if ( ( history_stream = fopen("history.txt", "a+") ) == NULL )
    {
        perror("Bash");
    }
...

    strcat(linebuf, "\n");
    fputs(linebuf, history_stream);
    fflush(history_stream); 

EDIT: just realised its not the fputs cutting the string down,

after doing a

fprintf(stdout, "%s\n", linebuf); 

just before fputs, i realised that linebuf has been cut down.

[hk_mp5kpdw]

If you read the string stored in linebuf from the user using something like scanf the problem is likely because the scanf call stopped storing the user's input after the first whitespace, in other words, scanf will stop after that first space following the word "hello". You need to use a different method for getting the input from the user, like fgets(linebuf,sizeof(linebuf),stdio) for example. The fgets function will store the newline character so you may have to deal with that.

[jamie85]

If you read the string stored in linebuf from the user using something like scanf the problem is likely because the scanf call stopped storing the user's input after the first whitespace, in other words, scanf will stop after that first space following the word "hello". You need to use a different method for getting the input from the user, like fgets(linebuf,sizeof(linebuf),stdio) for example. The fgets function will store the newline character so you may have to deal with that.

I was using fgets however i had this little piece of code

p = strchr(linebuf, '\n');

if (p)
    *p = '\0'; 

which was causing me the problem.

all fixed now thanks.