help with changing array

[forumer]

Hi,

I have a problem that has been bugging me for days

i have 2 arrays
A=[GGGGG GG GGGG GG GGGGG G G G ]
B=[10101100010101010101010101010110]

both are same in length

i need to change Array B in such a way that when Array A has a blank, the same position in Array B changes into character 'P'
below are my codes,this is a subroutine and arrays are predefined

int ABC()
{
 int i;

 for (i=0;i<=32;i++)
{if A[i] == ' '
 (B[i] = "P";)
}

}

Is there anything wrong with the logic or syntax? Pls help. thanks.

[Dave_Sinkula]

Quite a few little things I'd change, along with some bigger ones.

#include <stdio.h>

char A[] = "GGGGG GG GGGG  GG   GGGGG G G G ";
char B[] = "10101100010101010101010101010110";

void ABC()
{
   size_t i;
   for ( i = 0; i < sizeof A / sizeof *A - 1; ++i )
   {
      if ( A[i] == ' ' )
      {
         B[i] = 'P';
      }
   }
}

int main(void)
{
   printf("[%s]\n", A);
   printf("[%s]\n", B);
   puts("change:");
   ABC();
   printf("[%s]\n", A);
   printf("[%s]\n", B);
   return 0;
}

/* my output
[GGGGG GG GGGG  GG   GGGGG G G G ]
[10101100010101010101010101010110]
change:
[GGGGG GG GGGG  GG   GGGGG G G G ]
[10101P00P1010PP10PPP01010P0P0P1P]
*/

[edit]Perhaps I'd even use this for the loop condition instead.

   int i;
   for ( i = 0; A[i] != '\0'; ++i )

[edit=again, can't I do things right the first time?]
Is your array a char array? And is it a C-string? Such things make a difference in some of the choices I've made above.

[spydoor]

^ beat me

the syntax of your if statement is wrong

P is a single character, so you should use single quotes instead of double quotes

if(expression) 
{
   //do stuff
}

for (i=0;i<=32;i++)
{
   if (A[i] == ' ')
   {
      B[i] = 'P';
   }
}