fscan skipping a character

I have the following:

Code:

while(fgetc(bFile) != EOF)
{
   fscanf(bFile, "%s %lf %lf", custName, &totearn, &weekearn);
}

inside a text file i have:

sarah 4.4 7.7
john 3.3 8.8

when i run:

printf( "%s %lf %lf\n ", custName, totearn, weekearn);

i get the following:

arah 4.400000 7.700000
john 3.300000 8.800000
john 3.300000 8.800000



Why is the first character in the text skipped ? and why is "john" printed twice?

> Why is the first character in the text skipped ?
Because you called fgetc

> why is "john" printed twice?
Because you didn't check for errors.

>Because you called fgetc

So that's a normal result when using fgetc? Why the first character and not another?

>Because you didn't check for errors.

I think it's a problem with how i'm calling fgetc. If i was calling it properly then maybe it wouldn't give me a duplicate record.

Your first call of fgetc will get a character from the current line(sarah 4.4 7.7) which is 's'. Then the fscanf call will get the remaining chracters in the current line. Same with the seconds line

First line: "sarah 4.4 7.7"
Second line: "\njohn 3.3 8.8" //You have '\n' as your first charcter in this line thats why you output it completly. fgetc got '\n'.

What about use fscanf in while() rather than fgetc? or use fgets then sscanf()

You should not be calling fgetc like that. There are ways to deal with this, one is to use fgets to read a line of data from the file into a buffer and then to use sscanf to read from that buffer into your variables:

Code:

char buffer[100];
while( fgets(buffer,sizeof(buffer),bFile) != NULL )
{
    sscanf(buffer,"%s %f %f",custName,&totearn,&weekearn);

    ...

}

hmm that doesn't seem to work. i've tried printing the weekearn(just to test) and i just gives me:

nannannannannannannannannan

possibly because, sscanf(buffer,"%s %f %f",custName,&totearn,&weekearn);

isn't assigning the correct value.

Well you know, functions have return values for a reason. How about actually checking them once in a while?


Quzah.

> nannannannannannannannannan
Like all good examples, it gives you a hint, not an answer.

Use the %lf you originally had, since you're reading into double variables (not floats)

hk_mp5kpdw shows how to read a file line by line, with none of this "where's the first character" or "why a double line" problem associated with various other hacky ways of reading files - eg feof() abuse.