Thread: Error evaluating 'char'

I wrote a program that is supposed to evaluate a character that the user types in and tell the user if it's a number, a letter, etc.
The problem is that the program always goes to 'else' and returns the wrong answer!

Code:

#include <stdio.h>

int main()
{
    int cod;
    char c;

    cod= (int) c;

    printf("Type one character");
    scanf("%c", &c);
    if (cod<=57 && cod>=48){
        printf("You typed a number\n");
    }else if (cod>=97 && cod<=122) {
        printf("You typed a letter\n");
    }else if (cod>=33 && cod<=46){
        printf("You typed a punctuation sign\n");
        } else {
        printf("What you typed was not a letter, a punctuation sign or a number\n");
        }
return 0;
}

Thanks
Alastor

Code:

	printf("Type one character");
	scanf("%c", &c);

	if (cod <= '9' && cod >= '0')
	{
		printf("You typed a number\n");
	}
	// etc etc...

No need to convert the char to an integer value or use cryptic "magic-number" ASCII codes.

I was following the ASCII values Quzah, I tried another program before...

Code:

#include <stdio.h>

int main()
{
    int cod;
    char c;

    c='C';
    cod = (int) c;
   printf("C is %c and cod is %d", c,cod);
   }

Since cod returned a numerical value (In ASCII of course) I thought that the program I posted before would work
Thanks for the help!

EDIT: Tonto, what if I want to check for letters?

cod>='a' && cod<='z' ?

Prefer:

Code:

isdigit(cod)
isalpha(cod)

To:

Code:

(cod >= '0' && cod <= '9')
(cod >= 'a' && cod <= 'z')

so that's what isalpha is for...

Of course, isalpha will include uppercase letters as well, so you'd actually want islower() if you just wanted lowercase.