Problems with execvp and fork....

[LightsOut06]

Bool execute_command(char *input)
{
   pid_t child_pid;

   /* fork() == 0 for child process */

   if(child_pid == 0)
   {
      char *argv[]={input, 0};
      execvp(argv[0], argv);
      perror("execvp() failure!\n");

      printf("This print is after execl() and should not get executed\n");

      _exit(EXIT_FAILURE);
   }

   else if(child_pid > 0)
   {
      wait(0);
      return(TRUE);
   }

   else
   {
      perror("Fork Error. Quitting the Programing.\n");
      exit(EXIT_FAILURE);
   }
}

When the input is something like "ls" the program just hangs. I thought that is was the wait statement that made this so, so I took it out, im still getting the same results.

[LightsOut06]

here's some more code that exemplifies what i'm trying to do. Still having the same problem.

#define _GNU_SOURCE 1
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <getopt.h>
#include <sys/types.h>
#include <sys/wait.h>

typedef enum
{
   FALSE = 0,
   TRUE = 1
} Bool;

int main()
{
   pid_t child_pid;
   Bool stillGoing = TRUE;
   ssize_t readReturn = 0;
   size_t bufLen = 0;
   char *input = NULL;
   int x = 0;

   while(stillGoing)
   {
      printf("Enter some stuff ese: ");
      /* The buffer will contain the new line character and the null char */
      readReturn = getline(&input, &bufLen, stdin);
      
      /* Get rid of any new line that may be there. */
      for(x = 0; x < strlen(input) + 1; ++x)
      {
         if(input[x] == '\n')
         {
            input[x] = '\0';
         }
      } 
      
      if(readReturn == 5 && strncmp(input, "exit", 4) == 0)
      {
         stillGoing = FALSE;
         break;
      }

      if(child_pid == 0)
      {  
         char *argv[]={input, 0};
         execvp(argv[0], argv);
         perror("execvp() failure!\n");

         printf("This print is after execl() and should not get executed\n");
      
         _exit(EXIT_FAILURE);
      }
   
      else if(child_pid > 0)
      {
         wait(0);
      }

      else
      {
         perror("Fork Error. Quitting the Programing.\n");
         exit(EXIT_FAILURE);
      }
      input = NULL;
   }     
}

[Hammer]

Whereabouts do you think the problem is? Put some printf()s in there to help you debug it and find out exactly where the hang is occuring.

[LightsOut06]

the problem was that i never forked a new process. I dont know how i left that out lol.