Thread: Problem reading and analyzing 3 variables

This:

Code:

if x>y && x>z && y>z {

Needs to be this:

Code:

if( x>y && x>z && y>z ){

And likewise for your other else if statements.

... and you're still doing that void main thing others have told you about. It may work fine but it is really frowned upon and you should get in the habit of saying int main instead.

[edit]Almost forgot... you don't put & in front of the variables when you print them.[/edit]

Looking at your code, I can already see a half-dozen errors, and these are only related to syntax. Anyways, I re-written your stuff, as it should be corrected. I suggest you look at the comments I have left

Code:

#include <stdio.h>
int main()   /*** to avoid warning, put return type of main to int  ***/
{
    int x,y,z;
    printf("Escribe tres numeros\n");
    scanf("%d %d %d", &x, &y, &z);
    if (x>y && x>z && y>z)  /** parentheses  **/
    {
        printf("Big numer is %d Small number is %d\n", x,z);  /*** print values, not addresses ***/
    }
    else
    { 
       if (x>y && x>z && y<z)/** parentheses  **/
       {
          printf("Big numer is %d Small number is %d\n", x,y);/*** print values, not addresses ***/
       }
       else
       {
          if (y>x && y>z && x>z)/** parentheses  **/
          {
             printf("Big numer is %d Small number is %d\n", y,z);/*** print values, not addresses ***/
          }
          else
          { 
             if (y>x && y>z && x<z)/** parentheses  **/
             {
                printf("Big numer is %d Small number is %d\n",y,x);/*** print values, not addresses ***/
             }
             else
             { 
                if (z>x && z>y && y>x)/** parentheses  **/
                {
                   printf("Big numer is %d Small number is %d\n", z,x);/*** print values, not addresses ***/
                }
                else
                {
                   printf("Big numer is %d Small number is %d\n", z,y);/*** print values, not addresses ***/
                }
             }  /** forgottten brace  ***/
          }  /*  forgotten brace  ***/
       }   /* forgtotten brace ***/
   }
   
   return 0;   /**** to return int  ***/
}

Also, 'd%' in the middle of a printf statement will print 'd%'. I think what you wanted was '%d'. I took the liberty of correcting that too.

Also, 'd%' in the middle of a printf statement will print 'd%'.

Actually, it will print 'd' followed by whatever special escape character translation printf() makes depending on the character immediately following the %. In this program's case it tries to convert %\ which it doesn't understand and will give you some error message related to that. To print '%' using printf() you need to tell printf() to print "%%".

Well sure! If you're looking to write illegal C code then void main() is a great way to accomplish it. Everything is useful at some time to someone.

Originally Posted by cwr

See http://homepages.tesco.net/~J.deBoyn...void-main.html for why blanket statements like "void main is illegal" are wrong.

Q - How many [...] engineers does it take to change a light bulb?
A - None. [...] will just redefine Darkness (TM) to be the new industry standard.

C90 was the standard, once.