reading data from file and storing into array of structs

hi im trying to read the movie title, rating, date and length from a file and tryingto store it into an array of structs here is how the data file is

Code:

---

Meet the Parents,PG,03/06/2001,108
Meet the Fockers,PG-13,04/19/2005,116
Fantastic Four,PG-13,07/10/2005,99
Harry Potter: Prisoner of Azkaban,Not-Rated,11/23/2004,142
Hitch,PG-13,07/02/2005,103

---

and the code ive written so far

Code:

---


#define SIZE 10
struct{
char title[30];
char rating[40];
char date[40];
int length;
} movies[SIZE];
int main()
{
   
    int i;
    char          name[100];  /* name of the file to use  */
    FILE          *in_file;    /* file for input */
    printf("Name? ");
    fgets(name, sizeof(name), stdin);
    name[strlen(name)-1] = '\0';

    in_file = fopen(name, "r");
    if (in_file == NULL) {
        fprintf(stderr, "Could not open file\n");
        exit(8);
    }

          fscanf(in_file, "%[^,]s,%[^,]s,%[^,]s,%d", &movies[1].title, &movies[1].rating,&movies[1].date,&movies[1].length);             
    fclose(in_file);
          printf("Name of Movie:%s - Rating:%s - Date:%s - Length:%d",movies[1].title, movies[1].rating,movies[1].date,movies[1].length);
    getch();
    return (0);
}

---

i compiled it and this is what is displayed

Quote:

---

Name? input.txt
Name of Movie:Meet the Parents - Rating:= - Date: - Length:0

---

also how would i go about doing it for the nextline as this is a test for only one line

Code:

---

movies[1]

---

That should be movies[0]. movies[1] isn't defined.

If you have an array

Code:

---

int array[10];

---

Then the addressable elements are 0, 1, 2, 3, 4, 5, 6, 7, 8, and 9. So the last addressable element is 9, which is one less than the array's size. Since you declared the array as

Code:

---

#define SIZE 1
movies[SIZE];

---

then the last, and first, element is 0. 1 doesn't exist.

Quote:

---

Originally Posted by dwks

If you have an array

Code:

---

int array[10];

---

Then the addressable elements are 0, 1, 2, 3, 4, 5, 6, 7, 8, and 9. So the last addressable element is 9, which is one less than the array's size. Since you declared the array as

Code:

---

#define SIZE 1
movies[SIZE];

---

then the last, and first, element is 0. 1 doesn't exist.

---

sry i edited the code what i compiled was size as 10, still having trouble displaying the correct results

new updated code

Code:

---


#include <stdio.h>
#include <stdlib.h>       
#include <conio.h>
#define SIZE 4
struct{
char title[36];
char rating[11];
char date[11];
char length[3];
} movies[SIZE];
int main()
{
   
    int i;
    char          name[100];  /* name of the file to use  */
    FILE          *in_file;    /* file for input */
    printf("Name? ");
    fgets(name, sizeof(name), stdin);
    name[strlen(name)-1] = '\0';

    in_file = fopen(name, "r");
    if (in_file == NULL) {
        fprintf(stderr, "Could not open file\n");
        exit(8);
    }
    for (i=0;i<=SIZE;i++)
    {
          fscanf(in_file, "%35[^,],%10[^,],%10[^,],%s",movies[i].title, movies[0].rating,movies[i].date,&movies[i].length);             
          printf("Name of Movie:%s - Rating:%s - Date:%s - Length:%s\n",movies[i].title, movies[i].rating,movies[i].date,movies[i].length); 
          }
    fclose(in_file);
 
             
    getch();
    return (0);
}

---

OUTPUT:

Quote:

---

Name? input.txt
Name of Movie:Meet the Fockers - Rating:PG-13 - Date:04/19/2005 - Length:116
Name of Movie:
Meet the Parents - Rating: - Date:03/06/2001 - Length:108
Name of Movie:
Fantastic Four - Rating: - Date:07/10/2005 - Length:99
Name of Movie:
Harry Potter: Prisoner of Azkaban - Rating: - Date:11/23/2004 - Length:142
Name of Movie:
Hitch - Rating: - Date:07/02/2005 - Length:103

---

any1 know why the rating is not being displayed after the first one
nm got it stupid mistake =)))

> #include <conio.h>
This suggests to me that your compiler is very old, as does your use of getch() at the end of the program.

> char length[3];
Is too short to hold say
Hitch,PG-13,07/02/2005,103

> for (i=0;i<=SIZE;i++)
For array[n], the subscripts are 0 to n-1, not 0 to n
So it's for (i=0;i<SIZE;i++)

> fscanf(in_file, "%35[^,], ..
You know you can fold long lines like this to make the code more readable.

Code:

---

for (i=0;i<SIZE;i++)
{
  fscanf ( in_file, "%35[^,],%10[^,],%10[^,],%2s",
          movies[i].title, movies[i].rating,
          movies[i].date, movies[i].length );
  printf ( "Name of Movie:%s - Rating:%s - Date:%s - Length:%s\n",
          movies[i].title, movies[i].rating,
          movies[i].date,movies[i].length );
}

---

You specified sizes for everything else, why not for the final field?