Another rock paper scissor question

Hi,

New to these forums.

I have a rock paper scissor program I need to change and for some reason can't quite see where I need to do the change. I'm sure it's easy but I can't see it.

I want to change the output from just saying "You win"
to You chose (paper rock or scissors) and I chose (paper rock or scissors. You win, You lose or You Tie.

So for instance if I won with paper and the computer lost with rock it would say:

"You chose paper and I chose rock. You win."

Thanks in advance for any help.

mattflick

Here's the code:

Code:

/*The game of paper, rock, and scissors. */

#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include <time.h>

enum p_r_s {paper, rock, scissors,
game, help, instructions, quit};

enum outcome {win, lose, tie, erro};

typedef		enum p_r_s		p_r_s;
typedef		enum outcome	outcome;

outcome		compare(p_r_s player_choice, p_r_s machine_choice);
void		prn_final_status(int win_cnt, int lose_cnt);
void		prn_game_status(int win_cnt,
							int lose_cnt, int tie_cnt);

void		prn_help(void);
void		prn_instructions(void);
void		report(outcome result, int *win_cnt_ptr,
				   int *lose_cnt_ptr, int *tie_cnt_ptr);
p_r_s		selection_by_machine(void);
p_r_s		selection_by_player(void);

Code:

#include "p_r_s.h"

int main(void)
{
	int			win_cnt = 0, lose_cnt = 0, tie_cnt = 0;
	outcome		result;
	p_r_s		player_choice, machine_choice;

	srand(time(NULL));
	prn_instructions();

	while	((player_choice = selection_by_player()) != quit)
		switch (player_choice) {
			case paper:
			case rock:
			case scissors:
				machine_choice = selection_by_machine();
				result = compare(player_choice, machine_choice);
				report(result, &win_cnt, &lose_cnt, &tie_cnt);
				break;
			case game:
				prn_game_status(win_cnt, lose_cnt, tie_cnt);
				break;
			case instructions:
				prn_instructions();
				break;
			case help:
				prn_help();
				break;
			default:
				printf("PROGRAMMER ERROR: Cannot get to here!\n\n");
				exit(1);
		}
	prn_game_status(win_cnt, lose_cnt, tie_cnt);
	prn_final_status(win_cnt, lose_cnt);
	return 0;
}

Code:

#include "p_r_s.h"

void prn_final_status(int win_cnt, int lose_cnt)
{
	if (win_cnt > lose_cnt)
		printf("CONGRATULATIONS - You win!\n\n");
	else if (win_cnt == lose_cnt)
		printf("A DRAW - You tied!\n\n");
	else
		printf("SORRY - You lost!\n\n");
}


void prn_game_status(int win_cnt, int lose_cnt, int tie_cnt)
{
	printf("\n%s\n%s%4d\n%s%4d\n%s%4d\n%s%4d\n\n",
		"GAME STATUS:",
		"	Win:	", win_cnt,
		"	Lose:	", lose_cnt,
		"	Tie:	", tie_cnt,
		"	Total:	", win_cnt + lose_cnt + tie_cnt);
}

void prn_help(void)
{
	printf("\n%s\n",
		"The following characters can be used for input:\n"
		"	p	for paper\n"
		"	r	for rock\n"
		"	s	for scissors\n"
		"	g	print the game status\n"
		"	h	help, print this list\n"
		"	i	reprint the instructions\n"
		"	q	quit this game\n");
}

void prn_instructions(void)
{
	printf("\n%s\n",
		"PAPER, ROCK, SCISSORS:\n"
		"\n"
		"In this game\n"
		"\n"
		"	p is for \"paper\"\n"
		"	r is for \"rock\"\n"
		"	s is for \"scissors\"\n"
		"\n"
		"Both player and the machine will choose one\n"
		"of p, r, or s. If the two chcices are the same,\n"
		"then the game is a tie. Otherwise:\n"
		"\n"
		"	\"paper covers the rock\"		(a win for paper)\n"
		"	\"rock breaks the scissors\"	(a win for rock)\n"
		"	\"scissors cut the paper\"		(a win for scissors)\n"
		"\n"
		"There are other allowable inputs:\n"
		"	g for game status	(print number of wins)\n"
		"	h for help			(print short instructions)\n"
		"	i for instructions	(print these instructions)\n"
		"	q for quit			(quit the game)\n"
		"\n"
		"This game is played repeatedly until q is entered.\n"
		"\n"
		"Good luck!\n");
}

Code:

#include "p_r_s.h"

p_r_s selection_by_machine(void)
{
	return ((p_r_s) (rand() % 3));
}

p_r_s selection_by_player(void)
{
	char	c;
	p_r_s	player_choice;

	printf("Input p, r, or s:	");
	scanf("%c", &c);
	switch (c) {
	case 'p':
		player_choice = paper;
		break;
	case 'r':
		player_choice = rock;
		break;
	case 's':
		player_choice = scissors;
		break;
	case 'g':
		player_choice = game;
		break;
	case 'i':
		player_choice = instructions;
		break;
	case 'q':
		player_choice = quit;
		break;
	default:
		player_choice = help;
		break;
	}
	return player_choice;
}

Code:

#include "p_r_s.h"

outcome compare(p_r_s player_choice, p_r_s machine_choice)
{
	outcome		result;

	if (player_choice == machine_choice)
		return tie;
	switch (player_choice) {
	case paper:
		result = (machine_choice == rock) ? win : lose;
		break;
	case rock:
		result = (machine_choice == scissors) ? win : lose;
		break;
	case scissors:
		result = (machine_choice == paper) ? win : lose;
		break;
	default:
		printf("PROGRAMMER ERROR: Unexpected choice!\n\n");
		exit(1);
	}
	return result;
}

Code:

#include "p_r_s.h"

void report(outcome result, int *win_cnt_ptr,
			int *lose_cnt_ptr, int *tie_cnt_ptr)
{			
	switch (result) {
	case win:
		++*win_cnt_ptr;
		printf("%27sYou win. \n", "");
		break;
	case lose:
		++*lose_cnt_ptr;
		printf("%27sYou lose. \n", "");
		break;
	case tie:
		++*tie_cnt_ptr;
		printf("%27sYou tie. \n", "");
		break;
	default:
		printf("PRGORAMMER ERROR: Unexpected result!\n\n");
		exit(1);
	}
}

hi mattflick,

you posted your "question" in the wrong forum... the right one would be "PLEASE DO MY HOMEWORK"

jmgk

Can someone at least point me in the right direction? I'm not where to apply the code too. I'm just asking for a nudge.

Originally Posted by mattflick

I want to change the output from just saying "You win" to You chose (paper rock or scissors) and I chose (paper rock or scissors. You win, You lose or You Tie.

Perhaps something like this.

Code:

void report(outcome result, int *win_cnt_ptr,
            int *lose_cnt_ptr, int *tie_cnt_ptr,
            p_r_s player_choice, p_r_s machine_choice)
{
   static const char *text[] = { "paper", "rock", "scissors" };
   printf("You chose %s, Machine chose %s : You ", 
          text[player_choice], text[machine_choice]);
   switch ( result )
   {
   case win:
      ++*win_cnt_ptr;
      puts("win.");
      break;
   case lose:
      ++*lose_cnt_ptr;
      puts("lose.");
      break;
   case tie:
      ++*tie_cnt_ptr;
      puts("tie.");
      break;
   default:
      printf("PRGORAMMER ERROR: Unexpected result!\n\n");
      exit(1);
   }
}

Wow I really suck a this stuff. I would have never thought that. I was thinking if was going have to be an "if" statement followed by multiple "printf" lines utilizing the player_choice and machine_choice. Thanks for the help and better understanding.

Hey Dave,

It builds with no with no failures, but when I execute it without debugging, if I press r s p for rock, paper or scissor it wants to debug and breaks at the following line:

Code:

text[player_choice],text[machine_choice]);

Any ideas?

You did make corresponding changes to the prototype and calling code, right?

I changed it too exactly what was shown above.

Look in the file p_r_s.h. There will be a prototype for the report function, it needs to correspond to the definition that Dave_Sinkula changed.

...And you now call it like this?

Code:

		switch (player_choice) {
			case paper:
			case rock:
			case scissors:
				machine_choice = selection_by_machine();
				result = compare(player_choice, machine_choice);
				report(result, &win_cnt, &lose_cnt, &tie_cnt, player_choice, machine_choice);
				break;

I changed the p_r_s.h to the below:

Code:

#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include <time.h>

enum p_r_s {paper, rock, scissors,
game, help, instructions, quit};

enum outcome {win, lose, tie, erro};

typedef		enum p_r_s		p_r_s;
typedef		enum outcome	outcome;

outcome		compare(p_r_s player_choice, p_r_s machine_choice);
void		prn_final_status(int win_cnt, int lose_cnt);
void		prn_game_status(int win_cnt,
							int lose_cnt, int tie_cnt);

void		prn_help(void);
void		prn_instructions(void);
void		report(outcome result, int *win_cnt_ptr,
				int *lose_cnt_ptr, int *tie_cnt_ptr, 
				p_r_s player_choice, p_r_s machine_choice);

p_r_s		selection_by_machine(void);
p_r_s		selection_by_player(void);

It's working. I changed it in the main.c and p_r_s.h and it's fine. My mistake. Need more attention to detail. Thanks for the help guys.