hi..stuck in sorting

[cBegginer]

hi..i try to implement the bubble sorting where it read from file..i mean line by line then break into token..it can break into token but it can't sort the words..
Eg. input

"this is a string"

output from the program.

"this
is 
a 
string"

output that i want..

"a 
is 
string 
this"

it seems like it din't pass any value into the bubbleSort..my bubble sort function can work with character by character but i jus want it works by words by words..can give some tips where i did wrong in my program??..thanks..

here is the program:

/* header file */
#include <stdio.h>
#include <stdlib.h>
typedef char* Item;

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "b.h"
#define M 50


int main()
{
    FILE *infile, *outfile;
    char line[1000], words[1000];
    char *token;
    char temp[1000];
    char *filename = "test.txt";
    char *delimeter = " ";
    
    if((infile = fopen(filename, "r")) == NULL)
    {
       printf("Error");
    }
    
    if (fgets(line, sizeof(line), infile) != NULL)
    {

    printf("%s\n", strtok(line, " "));

   while ( (token=strtok(NULL, " ")) != NULL)
   {
    bubble(&token, M);
    printf("%s\n", token);
    
   }
    
}
    return 0;
}

void bubble(Item a[], int N)
{
     int pass, pos;
     Item temp;
     for (pass = 1; pass < N; pass ++)
     
         for (pass = N - 1; pos >= pass; pos --)
         {
             if (a[pos] < a[pos-1])
             {
                 *temp = *a[pos];
                 *a[pos] = *a[pos-1];
                 *a[pos-1] = *temp;
             }
         }
}

[Happy_Reaper]

Is it just me or your output from your program is the same as the output you want (at least in your post) ?

[cBegginer]

hey man..sorry..i had type wrong the original output..n the code had been edited..sorry..

[dwks]

for (pass = 1; pass < N; pass ++)
     
         for (pass = N - 1; pos >= pass; pos --)
         {

Maybe that should be pos?

[dwks]

    Item temp;
             if (a[pos] < a[pos-1])
             {
                 *temp = *a[pos];
                 *a[pos] = *a[pos-1];
                 *a[pos-1] = *temp;
             }

Get rid of the asterisks. temp is not a pointer.

[loko]

Your passing the string one by one.

   while ( (token=strtok(NULL, " ")) != NULL)
   {
    bubble(&token, M);
    printf("%s\n", token);
    
   }

The first loop will pass the word "this" and sort its character. The printf will print "ihts" which is the sorted "this" string. and itll do that with the other tokenized words.

My suggestion is use a 2d array to pass the all strings. and use strcmp to compare strings.

         for (pass = N - 1; pos >= pass; pos --)
         {
             if (a[pos] < a[pos-1]) // replace this with strcmp
             {
                 *temp = *a[pos];
                 *a[pos] = *a[pos-1];
                 *a[pos-1] = *temp;
             }
         }

[dwks]

You didn't notice . . .

for (pass = N - 1; pos >= pass; pos --)

etc.

A 2D aray is a good idea.

[cbastard]

char *token;
bubble(&token, M);
typedef char* Item;
void bubble(Item a[], int N)

Array of pointers is not pointer to a pointer.although it is logically correct in C.but it is confusing so better go for array

[cBegginer]

hey..guys thanks for helping me out..